Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Jun 6, 2025

This reverts commit 7cbacf2.

What do these changes do?

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg added this to the Bazinga! milestone Jun 6, 2025
@sanderegg sanderegg self-assigned this Jun 6, 2025
@sanderegg sanderegg added the a:dask-service Any of the dask services: dask-scheduler/sidecar or worker label Jun 6, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 6, 2025

@sanderegg sanderegg requested a review from bisgaard-itis June 6, 2025 13:07
Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the quick fix.

@sanderegg sanderegg merged commit 3f0809d into ITISFoundation:master Jun 6, 2025
46 of 55 checks passed
@sanderegg sanderegg deleted the revert-print-file branch June 6, 2025 13:14
@codecov
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.68%. Comparing base (a4cb8aa) to head (d796c37).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (a4cb8aa) and HEAD (d796c37). Click for more details.

HEAD has 36 uploads less than BASE
Flag BASE (a4cb8aa) HEAD (d796c37)
unittests 32 1
integrationtests 6 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7848       +/-   ##
===========================================
- Coverage   86.73%   72.68%   -14.06%     
===========================================
  Files        1851      112     -1739     
  Lines       71983     5173    -66810     
  Branches     1218        0     -1218     
===========================================
- Hits        62435     3760    -58675     
+ Misses       9206     1413     -7793     
+ Partials      342        0      -342     
Flag Coverage Δ
integrationtests 61.64% <ø> (-2.58%) ⬇️
unittests 91.79% <100.00%> (+5.30%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk ∅ <ø> (∅)
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar 91.79% <100.00%> (+0.19%) ⬆️
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 ∅ <ø> (∅)
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 88.34% <ø> (-1.74%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 4.67% <ø> (-79.04%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4cb8aa...d796c37. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:dask-service Any of the dask services: dask-scheduler/sidecar or worker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New error when executing S4L Python Runner on osparc-staging.io

4 participants