Skip to content

Conversation

@sanderegg
Copy link
Member

What do these changes do?

  • This PR increases the timeout when retrieving results from the computational backend from 5 to 35 seconds.

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg requested review from GitHK and pcrespov as code owners June 6, 2025 14:06
@sanderegg sanderegg self-assigned this Jun 6, 2025
@sanderegg sanderegg added a:director-v2 issue related with the director-v2 service a:dask-service Any of the dask services: dask-scheduler/sidecar or worker labels Jun 6, 2025
@sanderegg sanderegg added this to the Bazinga! milestone Jun 6, 2025
@sanderegg sanderegg requested a review from bisgaard-itis June 6, 2025 14:06
@sanderegg sanderegg added the release Preparation for pre-release/release label Jun 6, 2025
@codecov
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.84%. Comparing base (c7929e1) to head (8224f65).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (c7929e1) and HEAD (8224f65). Click for more details.

HEAD has 31 uploads less than BASE
Flag BASE (c7929e1) HEAD (8224f65)
unittests 32 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7850       +/-   ##
===========================================
- Coverage   86.75%   67.84%   -18.92%     
===========================================
  Files        1851      703     -1148     
  Lines       71968    33582    -38386     
  Branches     1218      176     -1042     
===========================================
- Hits        62435    22783    -39652     
- Misses       9191    10741     +1550     
+ Partials      342       58      -284     
Flag Coverage Δ
integrationtests 64.18% <100.00%> (-0.16%) ⬇️
unittests 84.48% <100.00%> (-2.02%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.04% <ø> (-8.01%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 91.03% <100.00%> (-0.17%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 88.34% <ø> (-1.74%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 56.33% <ø> (-27.39%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7929e1...8224f65. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanderegg sanderegg force-pushed the increase-get-result-timeout branch from 502688f to 8224f65 Compare June 6, 2025 14:20
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 6, 2025

@sanderegg sanderegg added the 🤖-automerge marks PR as ready to be merged for Mergify label Jun 6, 2025
@sanderegg
Copy link
Member Author

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Jun 6, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 186af88

@mergify mergify bot merged commit 186af88 into ITISFoundation:master Jun 6, 2025
94 of 96 checks passed
@sanderegg sanderegg deleted the increase-get-result-timeout branch June 6, 2025 14:49
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:dask-service Any of the dask services: dask-scheduler/sidecar or worker a:director-v2 issue related with the director-v2 service release Preparation for pre-release/release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants