🐛 [Frontend] Fix: service catalog #7856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
bug
Contributor
There was a problem hiding this comment.
Pull Request Overview
A fix to prevent incomplete or null service metadata from breaking the service catalog by filtering out services missing inputs or outputs.
- Adds guard in service list retrieval to exclude null services and those without
inputsoroutputs - Updates catalog refresh to operate on the cleaned list
Comments suppressed due to low confidence (2)
services/static-webserver/client/source/class/osparc/workbench/ServiceCatalog.js:205
- Add unit tests covering the scenario where a service has missing inputs or outputs to verify the new filtering logic.
this.__servicesLatest = servicesList.filter(service => service !== null && service.inputs && service.outputs);
services/static-webserver/client/source/class/osparc/workbench/ServiceCatalog.js:204
- [nitpick] Consider expanding this comment to specify exactly which metadata fields are required (e.g.,
inputsandoutputs) and why they are critical for the catalog.
// first check metadata is complete
|
Member
Author
|
@Mergifyio queue |
Contributor
🟠 Waiting for conditions to match
|
odeimaiz
requested review from
GitHK,
giancarloromeo,
matusdrobuliak66,
pcrespov and
sanderegg
pcrespov
approved these changes
Jun 7, 2025
Member
|
Will checke validations in the backend as well |
giancarloromeo
approved these changes
Jun 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
If a service's metadata, which information is not complete or is null (e.g.
/project/servicesand this doesn't exist) makes into the service cache, it might break the service catalog. This PR takes care of this corner case (found in S4L staging).Buggy:
Related issue/s
How to test
Dev-ops