Skip to content

🎨 [Frontend] Account request form: adapt defaults #7894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 16, 2025
Merged

🎨 [Frontend] Account request form: adapt defaults #7894

merged 3 commits into from
Jun 16, 2025

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jun 13, 2025 •
edited
Loading

What do these changes do?

Context:
"""
In fields like "Application", users who don't make a choice end up with "Antenna design...". So POs are not actually able to distinguish users who actually chose "Antenna design..." from those who haven't chosen anything. An alternative would be to add a choice "Other" or "Not specified" and set this as default.

Same goes for "How did you hear about us?". Here we can easily change the default to "Other".
"""

This PR changes the default options in S4L's request account form.

  • Application: "Antenna Design for Wireless Communication" -> "Other"
  • Hear Options: "Search Engine" -> "Other"

NewDefaults

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz self-assigned this Jun 13, 2025
@odeimaiz odeimaiz added this to the Engage milestone Jun 13, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Jun 13, 2025
@odeimaiz odeimaiz requested a review from Copilot June 13, 2025 11:38
Copilot AI reviewed Jun 13, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the default selections in the S4L account request form by moving the “Other” option to the top for both the “Application” and “Hear Options” fields and removing the duplicate trailing entry in the hear options.

  • Moved “Other” to the first position in the Application dropdown
  • Moved “Other” to the first position in the Hear Options dropdown and removed its duplicate at the end
Comments suppressed due to low confidence (2)

services/static-webserver/client/source/class/osparc/auth/ui/RequestAccount.js:161

  • [nitpick] The id for "Other" is lowercase here, which is inconsistent with the Title_Case convention of other option ids (e.g., Antenna_Design_for_Wireless_Communication). Consider renaming it to "Other" (or matching your project’s id style) for consistency.
id: "other",

services/static-webserver/client/source/class/osparc/auth/ui/RequestAccount.js:290

  • [nitpick] This id uses Title_Case for "Other", but the application select uses lowercase. To prevent confusion and potential mismatches, align the casing of these ids across both dropdown definitions.
id: "Other",

@odeimaiz odeimaiz requested review from drniiken and eofli June 13, 2025 11:41
eofli
eofli approved these changes Jun 13, 2025
View reviewed changes
Copy link

@eofli eofli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Odei.

@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label Jun 13, 2025
@odeimaiz
Copy link
Member Author

odeimaiz commented Jun 13, 2025

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Jun 13, 2025 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The following conditions don't match anymore:

  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • any of: [🛡 GitHub branch protection]
        • check-neutral = system-tests
        • check-skipped = system-tests
        • check-success = system-tests

@mergify
Copy link
Contributor

mergify bot commented Jun 16, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@odeimaiz
Copy link
Member Author

odeimaiz commented Jun 16, 2025

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Jun 16, 2025 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 5d5eac3

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 16, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mergify mergify bot merged commit 5d5eac3 into ITISFoundation:master Jun 16, 2025
59 checks passed
This was referenced Jun 17, 2025
Closed
Closed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
Closed
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg sanderegg approved these changes

@drniiken drniiken Awaiting requested review from drniiken

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

+1 more reviewer

@eofli eofli eofli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@odeimaiz odeimaiz

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Milestone

Engage

Development

Successfully merging this pull request may close these issues.

Account request form: adapt defaults

5 participants

@odeimaiz @GitHK @pcrespov @sanderegg @eofli