-
Notifications
You must be signed in to change notification settings - Fork 32
🐛 fix webserver wallet exclusive queues are removed when they should not #7912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix webserver wallet exclusive queues are removed when they should not #7912
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7912 +/- ##
==========================================
- Coverage 87.98% 84.95% -3.03%
==========================================
Files 1845 691 -1154
Lines 71151 32642 -38509
Branches 1220 176 -1044
==========================================
- Hits 62602 27731 -34871
+ Misses 8197 4853 -3344
+ Partials 352 58 -294
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
...eb/server/src/simcore_service_webserver/notifications/_rabbitmq_exclusive_queue_consumers.py
Outdated
Show resolved
Hide resolved
odeimaiz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So if I understand correctly, you have multiple subscriptions to the same exchange, and the same for unsubscribing. and you are reference counting them.
Please change the comment. asyncio.Locks are not about thread-safety. see the documentation: https://docs.python.org/3/library/asyncio-sync.html#asyncio.Lock
...eb/server/src/simcore_service_webserver/notifications/_rabbitmq_exclusive_queue_consumers.py
Show resolved
Hide resolved
…:matusdrobuliak66/osparc-simcore into bugfix/wrong-removal-of-exclusive-queues
services/web/server/src/simcore_service_webserver/notifications/wallet_osparc_credits.py
Show resolved
Hide resolved
...eb/server/src/simcore_service_webserver/notifications/_rabbitmq_exclusive_queue_consumers.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/notifications/wallet_osparc_credits.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/notifications/wallet_osparc_credits.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_controller/nodes_rest.py
Outdated
Show resolved
Hide resolved
pcrespov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx. Left some suggestions
|
@mergify queue |
🟠 Waiting for conditions to match
|
|
1a1b0b2
into
ITISFoundation:master



What do these changes do?
Related issue/s
How to test
services/web/server/tests/unit/isolated/notifications/test_wallet_osparc_credits.pyDev-ops