Skip to content

Conversation

@matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Jun 16, 2025

What do these changes do?

Related issue/s

How to test

services/web/server/tests/unit/isolated/notifications/test_wallet_osparc_credits.py

Dev-ops

@matusdrobuliak66 matusdrobuliak66 self-assigned this Jun 16, 2025
@matusdrobuliak66 matusdrobuliak66 added bug buggy, it does not work as expected a:webserver webserver's codebase. Assigning the area is particularly useful for bugs labels Jun 16, 2025
@matusdrobuliak66 matusdrobuliak66 added this to the Engage milestone Jun 16, 2025
@codecov
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.95%. Comparing base (eccf0c0) to head (6fad762).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7912      +/-   ##
==========================================
- Coverage   87.98%   84.95%   -3.03%     
==========================================
  Files        1845      691    -1154     
  Lines       71151    32642   -38509     
  Branches     1220      176    -1044     
==========================================
- Hits        62602    27731   -34871     
+ Misses       8197     4853    -3344     
+ Partials      352       58     -294     
Flag Coverage Δ
integrationtests 64.23% <33.33%> (+<0.01%) ⬆️
unittests 86.77% <100.00%> (+0.19%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 76.86% <ø> (-8.19%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 77.70% <ø> (-13.36%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 88.33% <ø> (-1.77%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 87.59% <100.00%> (+0.04%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eccf0c0...6fad762. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review June 17, 2025 07:00
@matusdrobuliak66 matusdrobuliak66 changed the title 🐛 webserver exclusive queues are removed when they should not 🐛 webserver wallet exclusive queues are removed when they should not Jun 17, 2025
@matusdrobuliak66 matusdrobuliak66 changed the title 🐛 webserver wallet exclusive queues are removed when they should not 🐛 fix webserver wallet exclusive queues are removed when they should not Jun 17, 2025
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

…:matusdrobuliak66/osparc-simcore into bugfix/wrong-removal-of-exclusive-queues
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if I understand correctly, you have multiple subscriptions to the same exchange, and the same for unsubscribing. and you are reference counting them.
Please change the comment. asyncio.Locks are not about thread-safety. see the documentation: https://docs.python.org/3/library/asyncio-sync.html#asyncio.Lock

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) June 17, 2025 07:38
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx. Left some suggestions

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) June 17, 2025 09:40
@matusdrobuliak66
Copy link
Collaborator Author

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Jun 17, 2025

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images

@matusdrobuliak66 matusdrobuliak66 added the 🤖-automerge marks PR as ready to be merged for Mergify label Jun 17, 2025
@sonarqubecloud
Copy link

@matusdrobuliak66 matusdrobuliak66 merged commit 1a1b0b2 into ITISFoundation:master Jun 17, 2025
92 of 95 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:webserver webserver's codebase. Assigning the area is particularly useful for bugs bug buggy, it does not work as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Webserver exclusive queues are removed when they should not

5 participants