-
Notifications
You must be signed in to change notification settings - Fork 32
✨ [Frontend] Conversations: notify users #7916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [Frontend] Conversations: notify users #7916
Conversation
matusdrobuliak66
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for in-conversation user notifications by introducing a new notification category, enhancing backend enums and OpenAPI specs, and extending the frontend to post, display, and navigate to conversation notifications.
- Adds
CONVERSATION_NOTIFICATIONto backend enums and OpenAPI definitions - Implements new client methods for sending and rendering conversation notifications
- Refactors conversation components (
AddMessage,MessageUI,NotificationUI,Conversation) to handle notification entries
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| services/web/server/src/simcore_service_webserver/users/_notifications.py | Added CONVERSATION_NOTIFICATION enum and example payload |
| services/web/server/src/simcore_service_webserver/api/v0/openapi.yaml | Updated NotificationCategory enum to include new category |
| services/static-webserver/client/source/class/osparc/notification/Notifications.js | Created helpers for conversation notifications |
| services/static-webserver/client/source/class/osparc/notification/NotificationUI.js | Extended UI rendering to support new category |
| services/static-webserver/client/source/class/osparc/notification/Notification.js | Added CONVERSATION_NOTIFICATION enum value |
| services/static-webserver/client/source/class/osparc/conversation/NotificationUI.js | New widget for inline conversation notification messages |
| services/static-webserver/client/source/class/osparc/conversation/MessageUI.js | Generalized from comments to messages and adjusted layout |
| services/static-webserver/client/source/class/osparc/conversation/Conversation.js | Unified handling of messages & notifications in conversation |
| services/static-webserver/client/source/class/osparc/conversation/AddMessage.js | Combined “add comment” and “notify user” into one component |
| services/static-webserver/client/source/class/osparc/study/Conversations.js | Added notifyUser API call and switched to new component refs |
| services/static-webserver/client/source/class/osparc/share/NewCollaboratorsManager.js | Added single-selection mode for recipient picker |
| services/static-webserver/client/source/class/osparc/share/CollaboratorsStudy.js | Renamed notification method to pushStudyShared |
| services/static-webserver/client/source/class/osparc/dashboard/ResourceDetails.js | Added “Conversations” page to resource details |
| services/static-webserver/client/source/class/osparc/workbench/WorkbenchUI.js | Updated method call to new annotation-note API |
| services/static-webserver/client/source/class/osparc/ui/window/Confirmation.js | Refactored appearance logic binding for confirm buttons |
| services/static-webserver/client/source/class/osparc/editor/AnnotationNoteCreator.js | Simplified recipient selection flow |
| services/static-webserver/client/source/class/osparc/info/CommentAdd.js | Removed legacy comment component in favor of new UI |
Comments suppressed due to low confidence (2)
services/static-webserver/client/source/class/osparc/notification/Notifications.js:154
- [nitpick] For consistency with other methods (
pushNewAnnotationNote,pushStudyShared), consider renaming topushNewConversationNotification.
pushConversationNotification: function(userId, studyId) {
services/static-webserver/client/source/class/osparc/editor/AnnotationNoteCreator.js:181
- The variable
collaboratorsManageris not defined in this scope; it should refer to theusersManager(or the correct manager instance) to properly close the dialog.
.finally(() => collaboratorsManager.close());
services/static-webserver/client/source/class/osparc/conversation/Conversation.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/share/NewCollaboratorsManager.js
Show resolved
Hide resolved
|
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 6903354 |



What do these changes do?
This PR implements the Notifications between users within Project Conversations.
When User A notifies UserB:
/conversationscontaining the recipients' group id in its contentUser B:
User A:

User B:

Related issue/s
How to test
Dev-ops