Skip to content

Conversation

@matusdrobuliak66
Copy link
Collaborator

What do these changes do?

  • 🐛 FIX: Previously, upgrading a service version via the dashboard required the user to have access to a wallet connected to the project. This is no longer necessary. A user only needs access to a wallet if they are running a service.

Related issue/s

How to test

Dev-ops

@matusdrobuliak66 matusdrobuliak66 self-assigned this Jun 17, 2025
@matusdrobuliak66 matusdrobuliak66 added bug buggy, it does not work as expected a:webserver webserver's codebase. Assigning the area is particularly useful for bugs a:director-v2 issue related with the director-v2 service labels Jun 17, 2025
@matusdrobuliak66 matusdrobuliak66 added this to the Engage milestone Jun 17, 2025
@codecov
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 87.87%. Comparing base (1a1b0b2) to head (46a7481).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7917      +/-   ##
==========================================
- Coverage   88.00%   87.87%   -0.13%     
==========================================
  Files        1845      691    -1154     
  Lines       71162    32648   -38514     
  Branches     1220      176    -1044     
==========================================
- Hits        62625    28691   -33934     
+ Misses       8185     3899    -4286     
+ Partials      352       58     -294     
Flag Coverage Δ
integrationtests 64.25% <25.00%> (+0.08%) ⬆️
unittests 86.19% <25.00%> (-0.40%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.10% <ø> (-7.95%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 91.07% <100.00%> (-0.03%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 88.33% <ø> (-1.77%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 87.59% <14.28%> (-0.02%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a1b0b2...46a7481. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review June 17, 2025 12:52
…of github.com:matusdrobuliak66/osparc-simcore into bugfix/update-version-without-having-access-to-wallet
@sonarqubecloud
Copy link

@matusdrobuliak66 matusdrobuliak66 changed the title 🐛 Relax Wallet Access Check for Project Upgrades 🐛 Relax Wallet Access Check for Project Upgrades 🚨 Jun 17, 2025
@matusdrobuliak66 matusdrobuliak66 merged commit a50321d into ITISFoundation:master Jun 17, 2025
144 of 148 checks passed
@matusdrobuliak66
Copy link
Collaborator Author

Tested manually in aws master ✅

@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 20, 2025
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:director-v2 issue related with the director-v2 service a:webserver webserver's codebase. Assigning the area is particularly useful for bugs bug buggy, it does not work as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Currently to update a service version, user needs to have access to the project wallet

4 participants