🐛 [Frontend] Fix in_debt tracking #7927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
bug
odeimaiz
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a frontend bug where the debt status of a study was lost, preventing users from paying off debts and leaving projects embargoed.
- isInDebt now retrieves debt information via the centralized Store
- A new debt-tracking mechanism is added to the Store with methods setStudyDebt, getStudyDebt, and isStudyInDebt
- The ResourceDetails component now updates its resource debt information from the Store
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/study/Utils.js | Updates isInDebt to check debt via the Store |
| services/static-webserver/client/source/class/osparc/store/Store.js | Introduces debt tracking and relevant methods to store study debts |
| services/static-webserver/client/source/class/osparc/dashboard/ResourceDetails.js | Updates ResourceDetails to restore debt info from the Store |
services/static-webserver/client/source/class/osparc/dashboard/ResourceDetails.js
Outdated
Show resolved
Hide resolved
odeimaiz
requested review from
GitHK,
bisgaard-itis,
giancarloromeo,
matusdrobuliak66,
pcrespov and
sanderegg
odeimaiz
changed the title
GitHK
approved these changes
Jun 19, 2025
Member
Author
|
@mergify queue |
Contributor
🟠 Waiting for conditions to match
|
Member
Author
|
@mergify queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at a21f916 |
|
15 tasks
matusdrobuliak66
pushed a commit
that referenced
this pull request
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
When opening the project card, the frontend was loosing the
IN_DEBTinformation of it, not letting the users pay the debt and keeping the project embargoed until the fix was manually made in the DB. This PR fixes that situation by tracking the debts in the Store.Bonus:
@matusdrobuliak66 is there any other call where you attach the project_in_debt info?All goodBuggy:
Fixed:
Related issue/s
How to test
Dev-ops