🐛Ensure Dask client reference is uniquely defined for reference counting

[sanderegg]

What do these changes do?

A director-v2 replica keeps a dask-clients pool, each client is referenced counted since #7880.
The reference counting is using a reference that was defined using user_id and run_id. The run_id is an integer which does not ensure uniqueness. This means that some clients could maybe get deleted before the need. This would explain why restarting the director-v2 would fix it.

This PR fixes this issue by adding the project_uuid into the reference. Therefore it is now really unique.

Related issue/s

• fixes https://github.com/ITISFoundation/private-issues/issues/213

How to test

Dev-ops

[Copilot]

Pull Request Overview

This PR fixes a bug in the Dask client reference counting by ensuring that the reference string is unique through the addition of a project identifier.

• Updated the Dask client reference string to include "project_id".
• Added "project_id" as a new parameter to relevant functions and updated client pool calls accordingly.

Comments suppressed due to low confidence (1)

services/director-v2/src/simcore_service_director_v2/modules/comp_scheduler/_scheduler_dask.py:248

• The new formatting in _release_resources uses 'project_id' which is not defined in this scope. It should likely use 'comp_run.project_uuid' to ensure consistency with the other function calls.

                ref=_DASK_CLIENT_RUN_REF.format(

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.82%. Comparing base (a21f916) to head (e38545b).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (a21f916) and HEAD (e38545b). Click for more details.

HEAD has 31 uploads less than BASE

Flag	BASE (a21f916)	HEAD (e38545b)
unittests	32	1

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #7937       +/-   ##
===========================================
- Coverage   88.02%   69.82%   -18.20%     
===========================================
  Files        1846      691     -1155     
  Lines       71224    32665    -38559     
  Branches     1220      176     -1044     
===========================================
- Hits        62694    22808    -39886     
- Misses       8179     9799     +1620     
+ Partials      351       58      -293     

Flag	Coverage Δ
integrationtests	64.18% <100.00%> (-0.03%)	⬇️
unittests	84.57% <100.00%> (-2.06%)	⬇️

Components	Coverage Δ
api	∅ <ø> (∅)
pkg_aws_library	∅ <ø> (∅)
pkg_dask_task_models_library	∅ <ø> (∅)
pkg_models_library	∅ <ø> (∅)
pkg_notifications_library	∅ <ø> (∅)
pkg_postgres_database	∅ <ø> (∅)
pkg_service_integration	∅ <ø> (∅)
pkg_service_library	∅ <ø> (∅)
pkg_settings_library	∅ <ø> (∅)
pkg_simcore_sdk	76.86% <ø> (-8.25%)	⬇️
agent	∅ <ø> (∅)
api_server	∅ <ø> (∅)
autoscaling	∅ <ø> (∅)
catalog	∅ <ø> (∅)
clusters_keeper	∅ <ø> (∅)
dask_sidecar	∅ <ø> (∅)
datcore_adapter	∅ <ø> (∅)
director	∅ <ø> (∅)
director_v2	91.11% <100.00%> (+0.02%)	⬆️
dynamic_scheduler	∅ <ø> (∅)
dynamic_sidecar	88.33% <ø> (-1.77%)	⬇️
efs_guardian	∅ <ø> (∅)
invitations	∅ <ø> (∅)
payments	∅ <ø> (∅)
resource_usage_tracker	∅ <ø> (∅)
storage	∅ <ø> (∅)
webclient	∅ <ø> (∅)
webserver	58.91% <ø> (-28.72%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a21f916...e38545b. Read the comment docs.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sanderegg]

@mergify queue

[mergify]

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 11846e3