Skip to content

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented Jun 19, 2025

What do these changes do?

  • 🔨 Added a new prompt to convert Pydantic model fields to use the Annotated pattern
  • 🔨 Updated copilot-instructions.md
  • 🎨 Iteratively refined the prompt through testing:
    • Applied the prompt to various model examples
    • Identified errors and inaccuracies
    • Enhanced the prompt with additional context and details
    • Re-ran the prompt to validate improvements
  • ✅ Action item:
    • Everyone should apply the updated prompt to their own models and validate the output accordingly.

Related issue/s

How to test

  1. select a file
  2. run prompt from image

Dev-ops

@pcrespov pcrespov self-assigned this Jun 19, 2025
@pcrespov pcrespov added the t:maintenance Some planned maintenance work label Jun 19, 2025
@pcrespov pcrespov added this to the Engage milestone Jun 19, 2025
@pcrespov pcrespov marked this pull request as ready for review June 19, 2025 19:59
@pcrespov pcrespov enabled auto-merge (squash) June 19, 2025 20:01
@pcrespov
Copy link
Member Author

@mergify queue

@pcrespov pcrespov added the 🤖-automerge marks PR as ready to be merged for Mergify label Jun 19, 2025
@mergify
Copy link
Contributor

mergify bot commented Jun 19, 2025

queue

🛑 The pull request has been merged manually

The pull request has been merged manually at 4ee83ca

@codecov
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.03%. Comparing base (3ad6b04) to head (a576135).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7938      +/-   ##
==========================================
- Coverage   88.00%   85.03%   -2.97%     
==========================================
  Files        1846      691    -1155     
  Lines       71248    32667   -38581     
  Branches     1225      176    -1049     
==========================================
- Hits        62703    27779   -34924     
+ Misses       8192     4830    -3362     
+ Partials      353       58     -295     
Flag Coverage Δ
integrationtests 64.32% <100.00%> (+0.07%) ⬆️
unittests 86.84% <100.00%> (+0.23%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.04% <ø> (-8.01%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 77.93% <ø> (-13.16%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 88.33% <ø> (-1.77%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 87.63% <100.00%> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ad6b04...a576135. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcrespov pcrespov force-pushed the mai/pydantic-prompt branch from 5d97449 to fdf16d6 Compare June 22, 2025 12:06
@sonarqubecloud
Copy link

@pcrespov pcrespov merged commit 4ee83ca into ITISFoundation:master Jun 23, 2025
91 of 96 checks passed
@pcrespov pcrespov deleted the mai/pydantic-prompt branch June 23, 2025 09:16
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants