-
Notifications
You must be signed in to change notification settings - Fork 32
🎨 Send Socket.IO events whenever conversations are created, updated or deleted #7977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Send Socket.IO events whenever conversations are created, updated or deleted #7977
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7977 +/- ##
==========================================
+ Coverage 87.88% 89.69% +1.81%
==========================================
Files 1841 1445 -396
Lines 71009 59892 -11117
Branches 1227 476 -751
==========================================
- Hits 62404 53720 -8684
+ Misses 8251 6051 -2200
+ Partials 354 121 -233
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
odeimaiz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested 👌
pcrespov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
services/web/server/src/simcore_service_webserver/conversations/_conversation_service.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/conversations/_socketio.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/conversations/_socketio.py
Show resolved
Hide resolved
|
|
@mergify queue |
🟠 Waiting for conditions to match
|



What do these changes do?
This PR introduces new Socket.IO events sent whenever conversations are created, updated or deleted (See this other one for conversation messages: #7941).
Related issue/s
How to test
Dev-ops
Nothing to do