🎨 [Frontend] Enh: Preferred Wallet #7978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
Contributor
There was a problem hiding this comment.
Pull Request Overview
Enhances the preferred wallet selection logic to handle missing or invalid preference settings by preferring a personal wallet and falling back to the first available one.
- Broaden condition to apply when any wallets exist, not just a single one
- Introduce lookup for the user’s personal wallet in the group
- Add fallback to the first wallet if no personal wallet is found
services/static-webserver/client/source/class/osparc/store/Store.js
Outdated
Show resolved
Hide resolved
odeimaiz
requested review from
bisgaard-itis,
giancarloromeo,
matusdrobuliak66,
pcrespov and
sanderegg
Member
Author
|
@mergify queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 98caa3a |
Collaborator
|
It doesn't need to be hacky, since groups are not product-bound — that's why you can have access to multiple wallets when you're added to a second product and your user already belongs to some groups. |
matusdrobuliak66
approved these changes
Jun 25, 2025
sanderegg
approved these changes
Jun 26, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Reported by @bisgaard-itis ft. @matusdrobuliak66
This PR fixes a
hackysituation where the wallets are created manually in the DB.If the user gets access to two wallets without having a preferred wallet, this PR improves the logic by traying to choose the personal one.
Related issue/s
How to test
Dev-ops