Skip to content

Conversation

@giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Jun 26, 2025

What do these changes do?

This PR follows #7698 refactoring the async_jobs RPC routes and moving them to celery-library: this will allow a re-use for any other service that wants to monitor the new distributed queue tasks.

Related issue/s

How to test

cd packages/celery-library
pytest -vv --pdb tests/unit/test_async_jobs.py

Dev-ops

  • Nothing to do

@giancarloromeo giancarloromeo added this to the Engage milestone Jun 26, 2025
@giancarloromeo giancarloromeo self-assigned this Jun 26, 2025
@codecov
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.68%. Comparing base (2f1b484) to head (80b39ec).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7988      +/-   ##
==========================================
- Coverage   87.83%   87.68%   -0.15%     
==========================================
  Files        1805     1249     -556     
  Lines       69606    53181   -16425     
  Branches     1254      203    -1051     
==========================================
- Hits        61135    46630   -14505     
+ Misses       8106     6485    -1621     
+ Partials      365       66     -299     
Flag Coverage Δ
integrationtests 64.23% <ø> (-0.01%) ⬇️
unittests 85.77% <100.00%> (-0.63%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library 87.15% <100.00%> (+6.07%) ⬆️
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 84.99% <ø> (-0.06%) ⬇️
agent 96.29% <ø> (ø)
api_server 92.64% <ø> (ø)
autoscaling 96.03% <ø> (ø)
catalog 92.29% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 92.35% <ø> (+0.22%) ⬆️
datcore_adapter 97.94% <ø> (ø)
director 76.82% <ø> (+0.09%) ⬆️
director_v2 91.01% <ø> (-0.02%) ⬇️
dynamic_scheduler 96.69% <ø> (ø)
dynamic_sidecar 90.09% <ø> (ø)
efs_guardian 89.65% <ø> (ø)
invitations 93.60% <ø> (ø)
payments 92.57% <ø> (ø)
resource_usage_tracker 89.10% <ø> (∅)
storage 86.36% <100.00%> (+0.04%) ⬆️
webclient ∅ <ø> (∅)
webserver 82.42% <ø> (-5.26%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f1b484...80b39ec. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@giancarloromeo giancarloromeo changed the title ♻️ Refactor async_jobs RPC routes ♻️ Extract async_jobs RPC routes from simcore_service_storage Jun 27, 2025
@giancarloromeo giancarloromeo marked this pull request as ready for review June 27, 2025 07:32
…ancarloromeo/osparc-simcore into is7930/refactor-async-jobs-rpc-routes
Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution! Thanks

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@giancarloromeo giancarloromeo enabled auto-merge (squash) June 27, 2025 17:27
@sonarqubecloud
Copy link

@giancarloromeo giancarloromeo merged commit 2d1f459 into ITISFoundation:master Jun 27, 2025
96 of 97 checks passed
@giancarloromeo giancarloromeo deleted the is7930/refactor-async-jobs-rpc-routes branch June 30, 2025 09:50
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move async_jobs routes out from simcore_service_storage

5 participants