-
Notifications
You must be signed in to change notification settings - Fork 32
♻️ Extract async_jobs RPC routes from simcore_service_storage
#7988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Extract async_jobs RPC routes from simcore_service_storage
#7988
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7988 +/- ##
==========================================
- Coverage 87.83% 87.68% -0.15%
==========================================
Files 1805 1249 -556
Lines 69606 53181 -16425
Branches 1254 203 -1051
==========================================
- Hits 61135 46630 -14505
+ Misses 8106 6485 -1621
+ Partials 365 66 -299
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
async_jobs RPC routesasync_jobs RPC routes from simcore_service_storage
…ancarloromeo/osparc-simcore into is7930/refactor-async-jobs-rpc-routes
bisgaard-itis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice solution! Thanks
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
…ancarloromeo/osparc-simcore into is7930/refactor-async-jobs-rpc-routes
pcrespov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
|



What do these changes do?
This PR follows #7698 refactoring the
async_jobsRPC routes and moving them tocelery-library: this will allow a re-use for any other service that wants to monitor the new distributed queue tasks.Related issue/s
async_jobsroutes out fromsimcore_service_storage#7930How to test
Dev-ops