🎨 [Frontend] MM: Improve potential Function checks #7990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
changed the title
odeimaiz
changed the title
odeimaiz
added
t:enhancement
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the criteria for a Project to qualify as a Function by refining checks for parameters/probes, as well as ensuring the inclusion of computational services and the exclusion of dynamic services.
- Added helper methods extractComputationalServices and extractDynamicServices
- Renamed the function canCreateFunction to isPotentialFunction and updated its logic accordingly
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/study/Utils.js | Added functions to extract computational and dynamic services; updated the function criteria for potential Functions |
| services/static-webserver/client/source/class/osparc/dashboard/ResourceDetails.js | Updated reference from canCreateFunction to isPotentialFunction |
Comments suppressed due to low confidence (1)
services/static-webserver/client/source/class/osparc/study/Utils.js:253
- [nitpick] Consider renaming 'extractComputationalServices' and 'extractDynamicServices' to 'extractFunctionableComputationalServices' and 'extractFunctionableDynamicServices' respectively, to maintain consistency with the existing 'extractFunctionableParameters' and 'extractFunctionableProbes' methods.
extractComputationalServices: function(workbench) {
Member
Author
|
@mergify queue |
Contributor
🟠 Waiting for conditions to match
|
|
I would say that it needs BOTH at least one parameter and one probe. Also, regarding the no-interactive-service limitation, why is that an issue? Do not they simply get ignored? |
Member
Author
|
bisgaard-itis
approved these changes
Jun 27, 2025
Contributor
bisgaard-itis
left a comment
bisgaard-itis
left a comment
There was a problem hiding this comment.
Nice! Thanks a lot for the quick fix
Member
Author
|
@mergify queue |
|
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 5aa1302 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
In order to become a Function, a Project needs:
Related issue/s
How to test
Dev-ops