Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Jun 27, 2025

What do these changes do?

This pull request includes updates to dependency versions and Dockerfile configurations across multiple services and tools. The most important changes involve upgrading the UV_VERSION argument in Dockerfiles and updating pre-commit hooks for code formatting and sorting.

Dependency Version Updates:

  • .pre-commit-config.yaml: Updated pyupgrade to version v3.20.0 and isort to version 6.0.1. These are used for code upgrades and import sorting, respectively. [1] [2]

Dockerfile Configuration Updates:

  • Updated UV_VERSION from 0.6 to 0.7 across multiple Dockerfiles, including packages/postgres-database/docker/Dockerfile, services/api-server/Dockerfile, and others. This ensures all services and tools use the latest version of the UV base image. [1] [2] [3] and others)
  • Removed the pip upgrade command from the Makefile under the .venv target, simplifying the virtual environment creation process.

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg added this to the Engage milestone Jun 27, 2025
@sanderegg sanderegg self-assigned this Jun 27, 2025
@sanderegg sanderegg added the t:maintenance Some planned maintenance work label Jun 27, 2025
@sanderegg sanderegg requested a review from Copilot June 27, 2025 12:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the UV dependency from version 0.6 to 0.7 across many services, updates pre-commit tool revisions, and removes the pip upgrade commands from the Makefile.

  • Update UV_VERSION to "0.7" in multiple Dockerfiles
  • Bump pre-commit hook revisions for pyupgrade and isort
  • Remove the inline pip upgrade commands in the Makefile

Reviewed Changes

Copilot reviewed 29 out of 29 changed files in this pull request and generated no comments.

Show a summary per file
File Description
services/web/Dockerfile Updated UV_VERSION to "0.7"
services/storage/Dockerfile Updated UV_VERSION to "0.7"
services/resource-usage-tracker/Dockerfile Updated UV_VERSION to "0.7"
services/payments/Dockerfile Updated UV_VERSION to "0.7"
services/notifications/Dockerfile Updated UV_VERSION to "0.7"
services/migration/Dockerfile Updated UV_VERSION to "0.7"
services/invitations/Dockerfile Updated UV_VERSION to "0.7"
services/efs-guardian/Dockerfile Updated UV_VERSION to "0.7"
services/dynamic-sidecar/Dockerfile Updated UV_VERSION to "0.7"
services/dynamic-scheduler/Dockerfile Updated UV_VERSION to "0.7"
services/director/Dockerfile Updated UV_VERSION to "0.7"
services/director-v2/Dockerfile Updated UV_VERSION to "0.7"
services/datcore-adapter/Dockerfile Updated UV_VERSION to "0.7"
services/dask-sidecar/Dockerfile Updated UV_VERSION to "0.7"
services/clusters-keeper/Dockerfile Updated UV_VERSION to "0.7"
services/catalog/Dockerfile Updated UV_VERSION to "0.7"
services/autoscaling/Dockerfile Updated UV_VERSION to "0.7"
services/api-server/Dockerfile Updated UV_VERSION to "0.7"
services/agent/Dockerfile Updated UV_VERSION to "0.7"
scripts/pydeps-docker/Dockerfile Updated UV_VERSION to "0.7"
scripts/openapi/oas_resolver/Dockerfile Updated UV_VERSION to "0.7"
scripts/maintenance/migrate_project/Dockerfile Updated UV_VERSION to "0.7"
scripts/erd/Dockerfile Updated UV_VERSION to "0.7"
requirements/tools/Dockerfile Updated UV_VERSION to "0.7"
packages/service-integration/Dockerfile Updated UV_VERSION to "0.7"
packages/postgres-database/scripts/erd/Dockerfile Updated UV_VERSION to "0.7"
packages/postgres-database/docker/Dockerfile Updated UV_VERSION to "0.7"
Makefile Removed pip upgrade commands for uv-related tools
.pre-commit-config.yaml Upgraded pyupgrade and isort hook revisions

Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@sanderegg sanderegg added the 🤖-automerge marks PR as ready to be merged for Mergify label Jun 27, 2025
@sanderegg
Copy link
Member Author

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2025

queue

🟠 Waiting for conditions to match

  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

@sanderegg sanderegg requested a review from bisgaard-itis June 27, 2025 12:20
@codecov
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.08%. Comparing base (7f28bbc) to head (c98c189).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #8000       +/-   ##
===========================================
+ Coverage   77.45%   88.08%   +10.63%     
===========================================
  Files        1540     1565       +25     
  Lines       60706    62128     +1422     
  Branches     1103      623      -480     
===========================================
+ Hits        47017    54727     +7710     
+ Misses      13366     7236     -6130     
+ Partials      323      165      -158     
Flag Coverage Δ
integrationtests 64.28% <ø> (+0.13%) ⬆️
unittests 88.46% <ø> (+3.73%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 93.27% <ø> (ø)
pkg_notifications_library 85.26% <ø> (ø)
pkg_postgres_database 88.19% <ø> (∅)
pkg_service_integration 69.92% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.10% <ø> (ø)
agent 96.29% <ø> (ø)
api_server 92.64% <ø> (∅)
autoscaling 96.03% <ø> (∅)
catalog 92.29% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 91.79% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 76.73% <ø> (ø)
director_v2 77.75% <ø> (-13.20%) ⬇️
dynamic_scheduler 96.69% <ø> (ø)
dynamic_sidecar 90.09% <ø> (+1.76%) ⬆️
efs_guardian 89.65% <ø> (ø)
invitations 93.60% <ø> (ø)
payments 92.57% <ø> (ø)
resource_usage_tracker 89.05% <ø> (+0.05%) ⬆️
storage 86.27% <ø> (∅)
webclient ∅ <ø> (∅)
webserver 87.65% <ø> (+28.71%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f28bbc...c98c189. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@odeimaiz odeimaiz self-requested a review June 27, 2025 13:11
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unacceptable

@sanderegg sanderegg requested a review from odeimaiz June 27, 2025 14:22
@sanderegg
Copy link
Member Author

Unacceptable

come on, it happens to the best of us

@sanderegg
Copy link
Member Author

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2025

queue

🟠 Waiting for conditions to match

  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • any of: [🛡 GitHub branch protection]
        • check-neutral = system-tests
        • check-skipped = system-tests
        • check-success = system-tests
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@sanderegg
Copy link
Member Author

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Jun 28, 2025

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • any of: [🛡 GitHub branch protection]
        • check-neutral = system-tests
        • check-skipped = system-tests
        • check-success = system-tests
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

@sanderegg
Copy link
Member Author

@mergify requeue

@mergify
Copy link
Contributor

mergify bot commented Jun 29, 2025

requeue

☑️ This pull request is already queued

@sanderegg sanderegg merged commit 0816baa into ITISFoundation:master Jun 30, 2025
39 of 40 checks passed
@sanderegg sanderegg deleted the uv-update branch June 30, 2025 04:51
@sonarqubecloud
Copy link

@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants