✨ [Frontend] Search Templates and Search Public Projects #8013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
…-simcore into feature/search-templates
Member
Author
|
@mergify queue |
Contributor
🟠 Waiting for conditions to match
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds search functionality for templates and public projects, standardizes template fetching methods, and extends the study browser to support new search contexts.
- Introduces
searchTemplatesPaginatedand consolidates template fetching viafetchTemplatesPaginated - Extends the store and UI to handle three new contexts:
searchProjects,searchTemplates, andsearchPublicTemplates - Adjusts the resource container manager and filters to display context-appropriate “no resources” labels
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ColorLight.js | Removed a stray “OM here” comment |
| Templates.js | Renamed private fetch, added searchTemplatesPaginated |
| Store.js | Updated check list with new context keys |
| StudyLarge.js | Removed length limit from description markdown |
| ServiceUtils.js | Added “No description” fallback |
| Resources.js | Reordered query params and added search endpoint |
| WorkspaceButtonItem.js | Updated context check to use searchProjects |
| TutorialBrowser.js | Removed manual no‐resources label call |
| StudyBrowserHeader.js | Mapped new context keys to icons and titles |
| StudyBrowser.js | Overhauled context handling to include search contexts |
| ResourceContainerManager.js | Renamed evaluate method and switched label logic to __resourceType |
| ResourceBrowserFilter.js | Renamed “public” events to “publicTemplates” |
| FolderButtonItem.js | Updated context checks for rename and open-location in search view |
| ContextBreadcrumbs.js | Changed breadcrumb rendering condition |
| AppBrowser.js | Removed manual no‐resources label call |
Comments suppressed due to low confidence (1)
services/static-webserver/client/source/class/osparc/store/Templates.js:38
- New method
searchTemplatesPaginatedand its integration with the backend endpoint should have dedicated unit or integration tests to verify correct pagination, filtering, andresourceTypeassignment.
searchTemplatesPaginated: function(params, options) {
services/static-webserver/client/source/class/osparc/dashboard/ResourceContainerManager.js
Outdated
Show resolved
Hide resolved
…-simcore into feature/search-templates
odeimaiz
requested review from
bisgaard-itis,
giancarloromeo,
matusdrobuliak66,
pcrespov and
sanderegg
giancarloromeo
approved these changes
Jul 1, 2025
…-simcore into feature/search-templates
|
matusdrobuliak66
approved these changes
Jul 1, 2025
Collaborator
matusdrobuliak66
left a comment
matusdrobuliak66
left a comment
There was a problem hiding this comment.
Nice! I like the improvement of showing the search context.
Member
Author
|
@mergify queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 19a64fb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR implement the Search of Templates and Search of Public Projects.
Related issue/s
How to test
Dev-ops