-
Notifications
You must be signed in to change notification settings - Fork 32
🎨Improve testing on DB listener #8019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨Improve testing on DB listener #8019
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8019 +/- ##
==========================================
- Coverage 87.86% 84.22% -3.65%
==========================================
Files 1798 1775 -23
Lines 69119 68559 -560
Branches 1258 1182 -76
==========================================
- Hits 60733 57742 -2991
- Misses 8022 10474 +2452
+ Partials 364 343 -21
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
9647dc8 to
b61359e
Compare
matusdrobuliak66
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks
pcrespov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a good way to find out issues :-)
...ver/tests/unit/with_dbs/04/notifications/test_notifications__db_comp_tasks_listening_task.py
Show resolved
Hide resolved
...ver/tests/unit/with_dbs/04/notifications/test_notifications__db_comp_tasks_listening_task.py
Outdated
Show resolved
Hide resolved
...ver/tests/unit/with_dbs/04/notifications/test_notifications__db_comp_tasks_listening_task.py
Show resolved
Hide resolved
649a8ac to
2627be5
Compare
|



What do these changes do?
These changes are originaly from #8016 but were transfer to reduce the code changes needed for doing a hotfix.
test_notifications__db_comp_tasks_listening_task.pybrings a more robust test of the DB listener with the whole app and DB backendRelated issue/s
How to test
Dev-ops