Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Jul 1, 2025

What do these changes do?

These changes are originaly from #8016 but were transfer to reduce the code changes needed for doing a hotfix.

  • test_notifications__db_comp_tasks_listening_task.py brings a more robust test of the DB listener with the whole app and DB backend
  • this brings in some required changes in some faker in pytest-simcore, and some necessary changes are needed in other services to accomodate

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg added this to the Engage milestone Jul 1, 2025
@sanderegg sanderegg self-assigned this Jul 1, 2025
@sanderegg sanderegg added the t:maintenance Some planned maintenance work label Jul 1, 2025
@codecov
Copy link

codecov bot commented Jul 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.22%. Comparing base (fbde76d) to head (2627be5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8019      +/-   ##
==========================================
- Coverage   87.86%   84.22%   -3.65%     
==========================================
  Files        1798     1775      -23     
  Lines       69119    68559     -560     
  Branches     1258     1182      -76     
==========================================
- Hits        60733    57742    -2991     
- Misses       8022    10474    +2452     
+ Partials      364      343      -21     
Flag Coverage Δ
integrationtests 63.17% <ø> (-0.64%) ⬇️
unittests 83.50% <ø> (-3.00%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.93% <ø> (ø)
pkg_celery_library 87.15% <ø> (ø)
pkg_dask_task_models_library 79.62% <ø> (ø)
pkg_models_library 93.27% <ø> (ø)
pkg_notifications_library 85.26% <ø> (ø)
pkg_postgres_database 88.19% <ø> (ø)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 71.62% <ø> (ø)
pkg_settings_library 90.64% <ø> (ø)
pkg_simcore_sdk 76.86% <ø> (-8.25%) ⬇️
agent 96.29% <ø> (ø)
api_server 92.64% <ø> (ø)
autoscaling 96.03% <ø> (ø)
catalog 92.21% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 92.35% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 76.73% <ø> (-0.10%) ⬇️
director_v2 91.01% <ø> (+0.58%) ⬆️
dynamic_scheduler 96.69% <ø> (ø)
dynamic_sidecar 90.09% <ø> (ø)
efs_guardian 89.65% <ø> (ø)
invitations 93.60% <ø> (ø)
payments ∅ <ø> (∅)
resource_usage_tracker 89.05% <ø> (+0.16%) ⬆️
storage 86.44% <ø> (∅)
webclient ∅ <ø> (∅)
webserver 75.40% <ø> (-12.24%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbde76d...2627be5. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanderegg sanderegg force-pushed the maintenance/improve-testing-db-listener branch 2 times, most recently from 9647dc8 to b61359e Compare July 3, 2025 06:36
@sanderegg sanderegg marked this pull request as ready for review July 3, 2025 06:38
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a good way to find out issues :-)

@sanderegg sanderegg added a:webserver webserver's codebase. Assigning the area is particularly useful for bugs a:director-v2 issue related with the director-v2 service labels Jul 3, 2025
@sanderegg sanderegg force-pushed the maintenance/improve-testing-db-listener branch from 649a8ac to 2627be5 Compare July 3, 2025 14:10
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 3, 2025

@sanderegg sanderegg merged commit 4090c55 into ITISFoundation:master Jul 3, 2025
56 of 60 checks passed
@sanderegg sanderegg deleted the maintenance/improve-testing-db-listener branch July 3, 2025 14:45
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:director-v2 issue related with the director-v2 service a:webserver webserver's codebase. Assigning the area is particularly useful for bugs t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants