Skip to content

🐛E2E: check for NOT_STARTED state instead of UNKNOWN #8024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 1, 2025
Merged

🐛E2E: check for NOT_STARTED state instead of UNKNOWN #8024

merged 3 commits into from
Jul 1, 2025

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Jul 1, 2025

What do these changes do?

since #7996 the default state on open is NOT_STARTED

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg added this to the Engage milestone Jul 1, 2025
@sanderegg sanderegg self-assigned this Jul 1, 2025
@sanderegg sanderegg added the t:maintenance Some planned maintenance work label Jul 1, 2025
@sanderegg sanderegg added e2e Bugs found by or related to the end-2-end testing 🤖-automerge marks PR as ready to be merged for Mergify labels Jul 1, 2025
@sanderegg
Copy link
Member Author

sanderegg commented Jul 1, 2025

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Jul 1, 2025 •
edited
Loading

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 1, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

matusdrobuliak66
matusdrobuliak66 approved these changes Jul 1, 2025
View reviewed changes
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

odeimaiz
odeimaiz approved these changes Jul 1, 2025
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@codecov
Copy link

codecov bot commented Jul 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.88%. Comparing base (9c0f57f) to head (1764af9).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8024      +/-   ##
==========================================
- Coverage   87.89%   87.88%   -0.02%     
==========================================
  Files        1853     1853              
  Lines       71478    71478              
  Branches     1258     1258              
==========================================
- Hits        62825    62815      -10     
- Misses       8289     8299      +10     
  Partials      364      364
Flag Coverage Δ *Carryforward flag
integrationtests 64.23% <ø> (-0.05%) ⬇️
unittests 86.49% <ø> (ø) Carriedforward from 9c0f57f

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library 93.93% <ø> (ø)
pkg_celery_library 87.15% <ø> (ø)
pkg_dask_task_models_library 79.62% <ø> (ø)
pkg_models_library 93.27% <ø> (ø)
pkg_notifications_library 85.26% <ø> (ø)
pkg_postgres_database 88.19% <ø> (ø)
pkg_service_integration 69.92% <ø> (ø)
pkg_service_library 71.63% <ø> (ø)
pkg_settings_library 90.64% <ø> (ø)
pkg_simcore_sdk 85.05% <ø> (ø)
agent 96.29% <ø> (ø)
api_server 92.64% <ø> (ø)
autoscaling 96.03% <ø> (ø)
catalog 92.29% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 92.35% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 76.73% <ø> (ø)
director_v2 91.01% <ø> (-0.05%) ⬇️
dynamic_scheduler 96.69% <ø> (ø)
dynamic_sidecar 90.09% <ø> (ø)
efs_guardian 89.65% <ø> (ø)
invitations 93.60% <ø> (ø)
payments 92.57% <ø> (ø)
resource_usage_tracker 89.00% <ø> (ø)
storage 86.36% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 87.64% <ø> (-0.04%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c0f57f...1764af9. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanderegg sanderegg merged commit 0136ef5 into ITISFoundation:master Jul 1, 2025
94 of 95 checks passed
@sanderegg sanderegg deleted the e2e/increase-waiting-time-to-open branch July 1, 2025 11:22
sanderegg added a commit that referenced this pull request Jul 3, 2025
@sanderegg
🐛E2E: check for NOT_STARTED state instead of UNKNOWN (#8024)
22829f0
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jul 2, 2025
Closed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
Closed
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@odeimaiz odeimaiz odeimaiz approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@bisgaard-itis bisgaard-itis bisgaard-itis approved these changes

Assignees

@sanderegg sanderegg

Labels

🤖-automerge marks PR as ready to be merged for Mergify e2e Bugs found by or related to the end-2-end testing t:maintenance Some planned maintenance work

Projects

None yet

Milestone

Engage

Development

Successfully merging this pull request may close these issues.

4 participants

@sanderegg @odeimaiz @matusdrobuliak66 @bisgaard-itis