-
Notifications
You must be signed in to change notification settings - Fork 32
✨👽️ Add log zip endpoints in api-server #8056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨👽️ Add log zip endpoints in api-server #8056
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8056 +/- ##
==========================================
+ Coverage 86.22% 88.20% +1.98%
==========================================
Files 1883 1889 +6
Lines 72419 72555 +136
Branches 1273 1273
==========================================
+ Hits 62444 64000 +1556
+ Misses 9599 8180 -1419
+ Partials 376 375 -1
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
services/api-server/src/simcore_service_api_server/api/routes/function_jobs_routes.py
Outdated
Show resolved
Hide resolved
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! just left a few comments for you to check. Thanks!
...ges/service-library/src/servicelib/rabbitmq/rpc_interfaces/director_v2/computations_tasks.py
Outdated
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/api/routes/computations_tasks.py
Outdated
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/api/rpc/_computations_tasks.py
Outdated
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/utils/computations_tasks.py
Outdated
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/utils/dask.py
Outdated
Show resolved
Hide resolved
...ges/service-library/src/servicelib/rabbitmq/rpc_interfaces/director_v2/computations_tasks.py
Show resolved
Hide resolved
|
@Mergifyio queue |
🟠 Waiting for conditions to match
|
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. I added 2 suggestions so that the code remain more or less clear
services/director-v2/src/simcore_service_director_v2/api/routes/computations.py
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/models/comp_tasks.py
Outdated
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/models/comp_tasks.py
Outdated
Show resolved
Hide resolved
c001aaa to
f358985
Compare
|
666dd44
into
ITISFoundation:master



What do these changes do?
taskssection as well as a new endpoint to zip logs from function jobs.pytest-simcoreto mock the new endpoints, so that they can be used and extended by tests in other services.Related issue/s
How to test
Dev-ops