Skip to content

Conversation

@bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Jul 7, 2025

What do these changes do?

  • Bump the minor version of the api-server and expose the tasks section as well as a new endpoint to zip logs from function jobs.
  • Adds an RPC endpoint in the director v2 to get the file ids of all log files generated by comutation nodes during a project run.
  • Add side effect fixtures in pytest-simcore to mock the new endpoints, so that they can be used and extended by tests in other services.

Related issue/s

How to test

Dev-ops

@bisgaard-itis bisgaard-itis self-assigned this Jul 7, 2025
@bisgaard-itis bisgaard-itis added a:storage issue related to storage service a:director-v2 issue related with the director-v2 service a:apiserver api-server service labels Jul 7, 2025
@bisgaard-itis bisgaard-itis added this to the Engage milestone Jul 7, 2025
@codecov
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

Attention: Patch coverage is 84.70588% with 26 lines in your changes missing coverage. Please review.

Project coverage is 88.20%. Comparing base (9b06506) to head (eacc504).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8056      +/-   ##
==========================================
+ Coverage   86.22%   88.20%   +1.98%     
==========================================
  Files        1883     1889       +6     
  Lines       72419    72555     +136     
  Branches     1273     1273              
==========================================
+ Hits        62444    64000    +1556     
+ Misses       9599     8180    -1419     
+ Partials      376      375       -1     
Flag Coverage Δ
integrationtests 64.24% <78.57%> (+0.03%) ⬆️
unittests 86.82% <84.70%> (+1.99%) ⬆️
Components Coverage Δ
pkg_aws_library 93.93% <ø> (ø)
pkg_celery_library 87.34% <ø> (ø)
pkg_dask_task_models_library 79.62% <ø> (ø)
pkg_models_library 93.26% <100.00%> (+<0.01%) ⬆️
pkg_notifications_library 85.26% <ø> (ø)
pkg_postgres_database 88.22% <ø> (ø)
pkg_service_integration 70.17% <ø> (ø)
pkg_service_library 71.51% <0.00%> (-0.21%) ⬇️
pkg_settings_library 90.45% <ø> (ø)
pkg_simcore_sdk 85.10% <ø> (+0.05%) ⬆️
agent 93.81% <ø> (ø)
api_server 93.02% <98.57%> (+0.16%) ⬆️
autoscaling 95.88% <ø> (ø)
catalog 92.34% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 92.37% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 76.14% <ø> (ø)
director_v2 91.06% <97.14%> (+0.16%) ⬆️
dynamic_scheduler 96.27% <ø> (ø)
dynamic_sidecar 90.06% <ø> (ø)
efs_guardian 89.76% <ø> (ø)
invitations 91.44% <ø> (ø)
payments 92.60% <ø> (ø)
resource_usage_tracker 92.55% <ø> (-0.16%) ⬇️
storage 86.39% <ø> (-0.34%) ⬇️
webclient ∅ <ø> (∅)
webserver 88.53% <ø> (+6.80%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b06506...eacc504. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! just left a few comments for you to check. Thanks!

@bisgaard-itis bisgaard-itis requested a review from sanderegg July 17, 2025 12:23
@bisgaard-itis bisgaard-itis enabled auto-merge (squash) July 17, 2025 12:25
@bisgaard-itis bisgaard-itis added the 🤖-automerge marks PR as ready to be merged for Mergify label Jul 17, 2025
@bisgaard-itis
Copy link
Contributor Author

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Jul 17, 2025

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. I added 2 suggestions so that the code remain more or less clear

@bisgaard-itis bisgaard-itis force-pushed the 114-expose-fileids-dirv2-and-logs-in-apiserver branch from c001aaa to f358985 Compare July 17, 2025 13:56
@sonarqubecloud
Copy link

@bisgaard-itis bisgaard-itis merged commit 666dd44 into ITISFoundation:master Jul 17, 2025
148 of 150 checks passed
@bisgaard-itis bisgaard-itis deleted the 114-expose-fileids-dirv2-and-logs-in-apiserver branch July 17, 2025 16:36
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:apiserver api-server service a:director-v2 issue related with the director-v2 service a:storage issue related to storage service Meta-modeling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants