🔨 Maintenance: cleanup qooxdoo compile scripts
#8062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcrespov
changed the title
qooxdoo compile scripts
pcrespov
requested review from
GitHK,
bisgaard-itis,
giancarloromeo,
matusdrobuliak66 and
sanderegg
odeimaiz
approved these changes
Jul 16, 2025
giancarloromeo
approved these changes
Jul 16, 2025
GitHK
approved these changes
Jul 16, 2025
Member
Author
|
@mergify queue |
Contributor
🛑 The pull request has been merged manuallyThe pull request has been merged manually at d6de2b6 |
|
Collaborator
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
In my local environment, the frontend fails to start in
develmode (make up-develormake up-devel-frontend).After debugging, we identified that
develandprodworkflows have diverged due to duplicated code. Over time, this led to inconsistencies between them.This PR aligns both workflows to restore functionality in
develmode. Nonentheless, it does not attempt a long-term fix, as that is outside the scope of this PR.This pull request includes updates to the
Makefile,docker-compose.yml, andDockerfilein theservices/static-webserver/clientdirectory to enhance build processes, improve environment configuration, and simplify Docker-related commands. The most important changes include restructuring Docker build commands, adding environment variables for memory management, and setting default values for Docker build arguments.Build process improvements:
services/static-webserver/client/Makefile: Restructured Docker build commands across multiple targets (compile,touch) to use the--debugflag and break down arguments for better readability. [1] [2]Environment configuration enhancements:
services/static-webserver/client/tools/docker-compose.yml: AddedNODE_OPTIONSenvironment variable to increase the maximum old space size for Node.js, improving memory management during development.Simplification of Docker build arguments:
services/static-webserver/client/tools/qooxdoo-kit/builder/Dockerfile: Set a default value (latest) for thetagargument to simplify the build process when no specific tag is provided.Minor adjustments to environment variables:
services/static-webserver/client/Makefile: Reordered and adjusted environment variables in theqx compilecommand for consistency and clarity.Related issue/s
How to test
Dev-ops