Skip to content

Conversation

@bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Jul 8, 2025

What do these changes do?

  • Refine the concept of the TaskContext. This object is passed around when manipulating celery tasks.
  • This PR refines the concepts in two ways:
    • We introduce a baseclass. This will play a role when we want more advanced filtering options. E.g. list all celery tasks submitted from the api-server for any user.
    • Add a client_name field. This will allow us to distinguish tasks submited by different services.

Related issue/s

How to test

Dev-ops

@bisgaard-itis bisgaard-itis self-assigned this Jul 8, 2025
@bisgaard-itis bisgaard-itis added this to the Engage milestone Jul 8, 2025
@codecov
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

Attention: Patch coverage is 70.42254% with 21 lines in your changes missing coverage. Please review.

Project coverage is 88.25%. Comparing base (415442c) to head (ceba30e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8076      +/-   ##
==========================================
- Coverage   88.28%   88.25%   -0.04%     
==========================================
  Files        1865     1866       +1     
  Lines       71889    71919      +30     
  Branches     1267     1268       +1     
==========================================
+ Hits        63470    63474       +4     
- Misses       8051     8077      +26     
  Partials      368      368              
Flag Coverage Δ
integrationtests 64.33% <100.00%> (+0.05%) ⬆️
unittests 86.86% <70.42%> (-0.04%) ⬇️
Components Coverage Δ
pkg_aws_library 93.93% <ø> (ø)
pkg_celery_library 87.34% <95.83%> (+0.19%) ⬆️
pkg_dask_task_models_library 79.62% <ø> (ø)
pkg_models_library 93.24% <100.00%> (+<0.01%) ⬆️
pkg_notifications_library 85.26% <ø> (ø)
pkg_postgres_database 88.22% <ø> (ø)
pkg_service_integration 70.17% <ø> (ø)
pkg_service_library 71.14% <0.00%> (-0.12%) ⬇️
pkg_settings_library 90.39% <ø> (ø)
pkg_simcore_sdk 84.99% <ø> (-0.12%) ⬇️
agent 96.29% <ø> (ø)
api_server 92.84% <100.00%> (+<0.01%) ⬆️
autoscaling 95.88% <ø> (ø)
catalog 92.58% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 91.79% <ø> (-0.57%) ⬇️
datcore_adapter 97.94% <ø> (ø)
director 76.86% <ø> (+0.09%) ⬆️
director_v2 91.15% <ø> (+0.11%) ⬆️
dynamic_scheduler 96.69% <ø> (ø)
dynamic_sidecar 90.09% <ø> (ø)
efs_guardian 89.65% <ø> (ø)
invitations 93.60% <ø> (ø)
payments 92.57% <ø> (ø)
resource_usage_tracker 92.09% <ø> (-0.38%) ⬇️
storage 86.51% <100.00%> (-0.39%) ⬇️
webclient ∅ <ø> (∅)
webserver 88.60% <100.00%> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 415442c...ceba30e. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bisgaard-itis bisgaard-itis marked this pull request as ready for review July 8, 2025 13:07
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trhx

@bisgaard-itis bisgaard-itis enabled auto-merge (squash) July 10, 2025 04:26
@sonarqubecloud
Copy link

@bisgaard-itis bisgaard-itis merged commit 3e05de4 into ITISFoundation:master Jul 10, 2025
144 of 150 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants