Skip to content

Conversation

@matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Jul 11, 2025

What do these changes do?

  • 🐛 Fix filtering of currently running jobs

Related issue/s

How to test

Dev-ops

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review July 11, 2025 09:50
@matusdrobuliak66 matusdrobuliak66 self-assigned this Jul 11, 2025
@matusdrobuliak66 matusdrobuliak66 added bug buggy, it does not work as expected a:webserver webserver's codebase. Assigning the area is particularly useful for bugs a:director-v2 issue related with the director-v2 service labels Jul 11, 2025
@matusdrobuliak66 matusdrobuliak66 added this to the Engage milestone Jul 11, 2025
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) July 11, 2025 09:57
@codecov
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.49%. Comparing base (23ec8aa) to head (0df43dc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8093      +/-   ##
==========================================
+ Coverage   88.26%   88.49%   +0.23%     
==========================================
  Files        1876      719    -1157     
  Lines       71998    33203   -38795     
  Branches     1269      176    -1093     
==========================================
- Hits        63548    29383   -34165     
+ Misses       8083     3762    -4321     
+ Partials      367       58     -309     
Flag Coverage Δ
integrationtests 64.38% <0.00%> (+0.02%) ⬆️
unittests 86.93% <100.00%> (+0.06%) ⬆️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.04% <ø> (-8.01%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 91.03% <100.00%> (-0.07%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 88.33% <ø> (-1.77%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 88.56% <ø> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23ec8aa...0df43dc. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@sonarqubecloud
Copy link

@matusdrobuliak66 matusdrobuliak66 merged commit 2bdc986 into ITISFoundation:master Jul 12, 2025
197 of 204 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:director-v2 issue related with the director-v2 service a:webserver webserver's codebase. Assigning the area is particularly useful for bugs bug buggy, it does not work as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

directorv2: _comp_runs_collections_repository query does not return a single row but multiple

5 participants