✨ Sends approval and rejection emails from the PO center (🚨)

[pcrespov]

What do these changes do?

• ✨ Sends approval (with invitation link) and rejection emails in the PO center
  • uses notification's library new templates
  • @giancarloromeo the email notification in account_service has to be replaced by a call the notification interface you are building up.
• ♻️ Splits user-accounts at the three levels: controller, service and repository

Related issue/s

• Related to ITISFoundation/private-issues#23

How to test

cd services/web/server
make install-dev
pytest -vv tests/unit/**/test_*registration*.py

🚨 Manual testing

Need to test the entire workflow when deployed to make sure that all configurations (email, encryption keys etc) are correct

• fill form
• open PO center
• approve/reject
• check email was received with correct data
• use invitation link to create a new user

Dev-ops

None

[codecov]

Codecov Report

Attention: Patch coverage is 83.17460% with 53 lines in your changes missing coverage. Please review.

Project coverage is 85.49%. Comparing base (83c06b5) to head (80d959e).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8094      +/-   ##
==========================================
- Coverage   88.26%   85.49%   -2.78%     
==========================================
  Files        1876      722    -1154     
  Lines       72000    33288   -38712     
  Branches     1269      176    -1093     
==========================================
- Hits        63552    28459   -35093     
+ Misses       8081     4771    -3310     
+ Partials      367       58     -309     

Flag	Coverage Δ
integrationtests	64.35% <33.65%> (+<0.01%)	⬆️
unittests	87.73% <83.17%> (+0.85%)	⬆️

Components	Coverage Δ
pkg_aws_library	∅ <ø> (∅)
pkg_celery_library	∅ <ø> (∅)
pkg_dask_task_models_library	∅ <ø> (∅)
pkg_models_library	∅ <ø> (∅)
pkg_notifications_library	∅ <ø> (∅)
pkg_postgres_database	∅ <ø> (∅)
pkg_service_integration	∅ <ø> (∅)
pkg_service_library	∅ <ø> (∅)
pkg_settings_library	∅ <ø> (∅)
pkg_simcore_sdk	77.16% <ø> (-7.83%)	⬇️
agent	∅ <ø> (∅)
api_server	∅ <ø> (∅)
autoscaling	∅ <ø> (∅)
catalog	∅ <ø> (∅)
clusters_keeper	∅ <ø> (∅)
dask_sidecar	∅ <ø> (∅)
datcore_adapter	∅ <ø> (∅)
director	∅ <ø> (∅)
director_v2	77.37% <ø> (-13.70%)	⬇️
dynamic_scheduler	∅ <ø> (∅)
dynamic_sidecar	88.33% <ø> (-1.77%)	⬇️
efs_guardian	∅ <ø> (∅)
invitations	∅ <ø> (∅)
payments	∅ <ø> (∅)
resource_usage_tracker	∅ <ø> (∅)
storage	∅ <ø> (∅)
webclient	∅ <ø> (∅)
webserver	88.52% <83.17%> (-0.08%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83c06b5...80d959e. Read the comment docs.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[odeimaiz]

👍

[GitHK]

Thanks

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud