Skip to content

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented Jul 15, 2025

What do these changes do?

This PR introduces new API features to support user phone number registration and begins integration with future 2FA workflows.

✨ Features

  • Bumped web-server API to 0.72.0
  • Added phone (nullable) to get_my_profile response
  • Introduced new endpoints for phone number registration flow:
    • my_phone_register
    • my_phone_resend (optional)
    • my_phone_confirm
  • Current implementation is feature-flagged under WEBSERVER_DEV_FEATURES_ENABLED
    • Uses a temporary fake confirmation code 123456
    • Final behavior pending full 2FA refactoring

ReDoc
image

♻️ Refactoring

  • Internal models cleaned up to support new and upcoming features

📌 Follow-up PR(s)

Related issue/s

  • First part of backend for ITISFoundation/private-issues#280

How to test

cd services/web/server
make install-dev
pytest -vv tests/unit/with_dbs/03/test_users_rest_profiles.py

Dev-ops

None

@pcrespov pcrespov self-assigned this Jul 15, 2025
@pcrespov pcrespov added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Jul 15, 2025
@pcrespov pcrespov added this to the Engage milestone Jul 15, 2025
@codecov
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

Attention: Patch coverage is 96.58120% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.05%. Comparing base (94aab0b) to head (c4213ef).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8106      +/-   ##
==========================================
+ Coverage   88.08%   90.05%   +1.97%     
==========================================
  Files        1832     1480     -352     
  Lines       70404    60827    -9577     
  Branches     1272      483     -789     
==========================================
- Hits        62013    54778    -7235     
+ Misses       8016     5927    -2089     
+ Partials      375      122     -253     
Flag Coverage Δ
integrationtests 64.26% <54.80%> (+0.01%) ⬆️
unittests 88.40% <96.58%> (+1.74%) ⬆️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 93.26% <100.00%> (+0.01%) ⬆️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.17% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.10% <ø> (+0.11%) ⬆️
agent 93.81% <ø> (ø)
api_server 92.85% <100.00%> (ø)
autoscaling 95.88% <ø> (ø)
catalog 92.34% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 92.37% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 76.14% <ø> (ø)
director_v2 91.04% <ø> (+0.02%) ⬆️
dynamic_scheduler 96.27% <ø> (ø)
dynamic_sidecar 90.05% <ø> (ø)
efs_guardian 89.76% <ø> (ø)
invitations 91.44% <ø> (ø)
payments 92.60% <ø> (ø)
resource_usage_tracker 92.65% <ø> (∅)
storage 86.77% <ø> (+0.08%) ⬆️
webclient ∅ <ø> (∅)
webserver 88.50% <96.15%> (+0.04%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94aab0b...c4213ef. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcrespov pcrespov changed the title WIP: Is280/update phone number ✨ webserver api: add phone registration endpoints and expose user phone field in profile Jul 15, 2025
@pcrespov pcrespov marked this pull request as ready for review July 15, 2025 17:37
@pcrespov pcrespov requested a review from sanderegg as a code owner July 15, 2025 17:37
@sonarqubecloud
Copy link

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pcrespov pcrespov enabled auto-merge (squash) July 16, 2025 07:13
@pcrespov pcrespov requested a review from bisgaard-itis July 16, 2025 07:13
@pcrespov pcrespov added the 🤖-automerge marks PR as ready to be merged for Mergify label Jul 16, 2025
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pcrespov pcrespov merged commit b026b90 into ITISFoundation:master Jul 16, 2025
95 of 96 checks passed
@pcrespov pcrespov deleted the is280/update-phone-number branch July 16, 2025 11:05
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants