♻️ TasksManager uses Redis for task data #8131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8131 +/- ##
==========================================
- Coverage 88.07% 88.02% -0.05%
==========================================
Files 1905 1871 -34
Lines 73166 72543 -623
Branches 1280 1260 -20
==========================================
- Hits 64444 63859 -585
+ Misses 8343 8308 -35
+ Partials 379 376 -3
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
added 24 commits
July 21, 2025 16:44
…nning-tasks-refactor-6
…ning-tasks-refactor-6
…nning-tasks-refactor-6
This reverts commit 9fbf1cf.
…nning-tasks-refactor-6
GitHK
changed the title
pcrespov
approved these changes
Aug 5, 2025
matusdrobuliak66
approved these changes
Aug 5, 2025
Collaborator
matusdrobuliak66
left a comment
matusdrobuliak66
left a comment
There was a problem hiding this comment.
I didn't check yet, but to unblock you I approve.
YuryHrytsuk
approved these changes
Aug 6, 2025
Contributor
YuryHrytsuk
left a comment
YuryHrytsuk
left a comment
There was a problem hiding this comment.
Do not forget to merge https://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/merge_requests/1498
giancarloromeo
approved these changes
Aug 6, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the TasksManager to use Redis for storing task data instead of in-memory storage, enabling better distributed task management across multiple service instances.
- Replaces in-memory task tracking with Redis-based storage for long-running tasks
- Implements task cancellation across different service instances via Redis
- Updates all services to properly configure Redis client SDK with
setup()calls
Reviewed Changes
Copilot reviewed 114 out of 115 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| services/web/server/src/simcore_service_webserver/long_running_tasks.py | Configures long running tasks with Redis settings and namespace |
| packages/service-library/src/servicelib/long_running_tasks/task.py | Major refactor to use Redis-based storage instead of in-memory tracking |
| packages/service-library/src/servicelib/redis/_client.py | Adds explicit setup() method and improves Redis health checking |
| packages/settings-library/src/settings_library/redis.py | Renames DISTRIBUTED_IDENTIFIERS database to LONG_RUNNING_TASKS |
| services/*/tests/ | Updates test configurations to use Redis for long running tasks |
Comments suppressed due to low confidence (1)
packages/service-library/src/servicelib/long_running_tasks/task.py:441
- The
_update_progressmethod is called frequently during task execution but performs Redis operations on every call. Consider implementing a debouncing mechanism or batching progress updates to reduce Redis load, especially for tasks that update progress very frequently.
except TaskNotFoundError:
services/web/server/src/simcore_service_webserver/projects/_crud_api_create.py
Show resolved
Hide resolved
packages/service-library/src/servicelib/long_running_tasks/_store/redis.py
Outdated
Show resolved
Hide resolved
added 4 commits
August 6, 2025 09:53
Contributor
Author
|
@Mergifyio queue |
Contributor
🟠 Waiting for conditions to match
|
|
Member
|
Force merged upon @GitHK request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
While the
asyncio.Taskis still attached and tracked by a single instance of the service, its associated data is stored in Redis.This change simplifies the fowling:
Changes:
RedisClientSDKthat caused it to hang when closingdistributed_identifiersRedis DB, which is now used for thelong_running_taskslrt_apimodule. When a task is cancelled, the intent is stored in Redis. If the copy of the service, that received the message can't handle it (does not have the task), it will be removed by the background task running on all copies of the service.Related issue/s
dynamic-sidecarclient using RabbitMQ (enables easier k8s migration) #7224How to test
Dev-ops