-
Notifications
You must be signed in to change notification settings - Fork 32
🎨 [Frontend] Enh: Show who is collaborating #8144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e into enh/group-avatars
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the frontend to show collaborative user activity through avatar groups in both the navigation bar and study cards. The changes implement real-time updates via WebSocket events to display who is currently collaborating on studies.
- Adds avatar group components to show active collaborators
- Implements WebSocket listener for real-time project state updates
- Refactors code to use utility functions for state management
- Updates navigation bar button styling for consistency
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| AvatarGroup.js | Changed to accept user group IDs instead of user objects and fetch user data asynchronously |
| NavigationBar.js | Added avatar group control and WebSocket listener for project state updates |
| Utils.js | Refactored project state handling into reusable utility functions |
| CardBase.js | Updated to use new state utility functions and show current collaborators |
| TasksButton.js | Removed hardcoded styling properties |
| NotificationsButton.js | Removed hardcoded styling properties |
| JobsButton.js | Removed hardcoded styling properties and adjusted layout |
| CreditsIndicatorButton.js | Removed hardcoded styling properties |
| StudyEditor.js | Removed manual timeout logic for project state updates |
Comments suppressed due to low confidence (1)
services/static-webserver/client/source/class/osparc/dashboard/CardBase.js:894
- [nitpick] The function name '__showCurrentUserGroupIds' is misleading as it doesn't actually show the user group IDs directly, but passes them to the avatar group component. Consider renaming to '__updateAvatarGroup' or '__setAvatarGroupUsers'.
__showCurrentUserGroupIds: function(currentUserGroupIds) {
services/static-webserver/client/source/class/osparc/ui/basic/AvatarGroup.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/ui/basic/AvatarGroup.js
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/navigation/NavigationBar.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/dashboard/CardBase.js
Show resolved
Hide resolved
matusdrobuliak66
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
|
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 57bf22a |
pcrespov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice!



What do these changes do?
This PR enhances the frontend to show collaborative user activity through avatar groups in both the Navigation Bar and Project Cards. The changes implement real-time updates via WebSocket events to display who is currently collaborating on projects.
projectStateUpdatedWEBSERVER_REALTIME_COLLABORATIONenv_varNote @sanderegg: there might be a missing message when a user exits the project without closing it.
Group Avatar on Project Card and Navigation Bar

Related issue/s
How to test
Dev-ops