Skip to content

Conversation

@giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Jul 23, 2025

What do these changes do?

Whenever we get a Function (Project/Solver), its UUID is part of the response. This field has been renamed from uid to uuid but not for Solver ones. 😞

This PR fixes that. 😃

Related issue/s

How to test

Dev-ops

@giancarloromeo giancarloromeo added this to the Engage milestone Jul 23, 2025
@giancarloromeo giancarloromeo self-assigned this Jul 23, 2025
@giancarloromeo giancarloromeo added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Jul 23, 2025
@codecov
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.91%. Comparing base (57bf22a) to head (9bf5fef).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8149      +/-   ##
==========================================
+ Coverage   87.33%   89.91%   +2.57%     
==========================================
  Files        1634     1487     -147     
  Lines       63095    61200    -1895     
  Branches     1280      496     -784     
==========================================
- Hits        55105    55025      -80     
+ Misses       7610     6047    -1563     
+ Partials      380      128     -252     
Flag Coverage Δ
integrationtests 64.16% <ø> (+12.14%) ⬆️
unittests 88.27% <100.00%> (+2.26%) ⬆️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 93.11% <100.00%> (+<0.01%) ⬆️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.19% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.05% <ø> (-0.06%) ⬇️
agent 93.81% <ø> (ø)
api_server 93.02% <ø> (∅)
autoscaling 95.88% <ø> (ø)
catalog 92.34% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 92.37% <ø> (∅)
datcore_adapter 97.94% <ø> (ø)
director 76.14% <ø> (ø)
director_v2 91.09% <ø> (+0.69%) ⬆️
dynamic_scheduler 96.27% <ø> (ø)
dynamic_sidecar 90.07% <ø> (ø)
efs_guardian 89.76% <ø> (ø)
invitations 91.44% <ø> (∅)
payments 92.60% <ø> (ø)
resource_usage_tracker 92.23% <ø> (∅)
storage 86.52% <ø> (∅)
webclient ∅ <ø> (∅)
webserver 88.13% <ø> (+0.53%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57bf22a...9bf5fef. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@giancarloromeo giancarloromeo marked this pull request as ready for review July 23, 2025 21:47
@sonarqubecloud
Copy link

@giancarloromeo giancarloromeo changed the title 🐛 Wrong uid property instead of uuid alias when getting solver function 🐛 Wrong uid property instead of uuid alias when getting Solver function Jul 23, 2025
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎄

@giancarloromeo giancarloromeo merged commit 18fed8a into ITISFoundation:master Jul 24, 2025
95 of 96 checks passed
@giancarloromeo giancarloromeo deleted the fix-uid-alias-when-getting-solver-function branch July 24, 2025 04:43
@wvangeit
Copy link
Contributor

Thank you @giancarloromeo 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants