Skip to content

🐛 Enhance response when retrieving Solver functions #8153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jul 28, 2025
Merged

🐛 Enhance response when retrieving Solver functions #8153

merged 15 commits into from
Jul 28, 2025

Conversation

@giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Jul 24, 2025 •
edited
Loading

What do these changes do?

This PR follows #8149 and fixes remaining issues when dealing with Solver functions.
Now both Project and Solver functions are properly retrieved (including class-specific data if required).

Related issue/s

How to test

cd services/web/server
pytest -vv --pdb tests/unit/with_dbs/04/functions_rpc/test_functions_controller_rest.py

Dev-ops

  • Nothing to do

@giancarloromeo giancarloromeo added this to the Engage milestone Jul 24, 2025
@giancarloromeo giancarloromeo self-assigned this Jul 24, 2025
@giancarloromeo giancarloromeo added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Jul 24, 2025
@codecov
Copy link

codecov bot commented Jul 24, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 42.73504% with 67 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.87%. Comparing base (f8bc96c) to head (d3e0c1c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8153      +/-   ##
==========================================
+ Coverage   88.08%   89.87%   +1.79%     
==========================================
  Files        1894     1494     -400     
  Lines       73026    61448   -11578     
  Branches     1279      496     -783     
==========================================
- Hits        64326    55228    -9098     
+ Misses       8320     6092    -2228     
+ Partials      380      128     -252
Flag Coverage Δ
integrationtests 64.18% <36.93%> (-0.06%) ⬇️
unittests 88.26% <42.73%> (+1.55%) ⬆️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 93.12% <100.00%> (+<0.01%) ⬆️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.19% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.05% <ø> (-0.06%) ⬇️
agent 93.81% <ø> (ø)
api_server 93.08% <ø> (ø)
autoscaling 95.88% <ø> (ø)
catalog 92.34% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 92.37% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 76.23% <ø> (+0.09%) ⬆️
director_v2 90.94% <ø> (-0.10%) ⬇️
dynamic_scheduler 96.27% <ø> (ø)
dynamic_sidecar 90.08% <ø> (ø)
efs_guardian 89.76% <ø> (ø)
invitations 91.44% <ø> (ø)
payments 92.60% <ø> (ø)
resource_usage_tracker 92.55% <ø> (+0.05%) ⬆️
storage 86.60% <ø> (+0.20%) ⬆️
webclient ∅ <ø> (∅)
webserver 88.04% <39.63%> (-0.17%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8bc96c...d3e0c1c. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@giancarloromeo giancarloromeo marked this pull request as ready for review July 25, 2025 09:36
odeimaiz
odeimaiz reviewed Jul 25, 2025
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

wvangeit
wvangeit approved these changes Jul 25, 2025
View reviewed changes
Copy link
Contributor

@wvangeit wvangeit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @giancarloromeo

GitHK
GitHK approved these changes Jul 25, 2025
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider my suggestions

@giancarloromeo
fix: remove unused logger
39ead96
@giancarloromeo
Merge branch 'is1905/fix-functions-endpoint-for-solvers' of github.co…
3bdabe2 
…m:giancarloromeo/osparc-simcore into is1905/fix-functions-endpoint-for-solvers
pcrespov
pcrespov approved these changes Jul 25, 2025
View reviewed changes
@giancarloromeo
Copy link
Contributor Author

giancarloromeo commented Jul 28, 2025

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Jul 28, 2025 •
edited
Loading

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
      • any of: [🛡 GitHub branch protection]
        • check-success = SonarCloud Code Analysis
        • check-neutral = SonarCloud Code Analysis
        • check-skipped = SonarCloud Code Analysis

@giancarloromeo giancarloromeo enabled auto-merge (squash) July 28, 2025 07:39
@giancarloromeo giancarloromeo added the 🤖-do-not-merge (optional) blocks Mergify from merging the PR label Jul 28, 2025
@giancarloromeo giancarloromeo added 🤖-automerge marks PR as ready to be merged for Mergify and removed 🤖-do-not-merge (optional) blocks Mergify from merging the PR labels Jul 28, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 28, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@giancarloromeo giancarloromeo merged commit d928d88 into ITISFoundation:master Jul 28, 2025
197 of 204 checks passed
@YuryHrytsuk YuryHrytsuk mentioned this pull request Jul 29, 2025
Closed
18 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
Closed
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@odeimaiz odeimaiz odeimaiz left review comments

@wvangeit wvangeit wvangeit approved these changes

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg sanderegg approved these changes

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66 matusdrobuliak66 is a code owner

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@giancarloromeo giancarloromeo

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Milestone

Engage

Development

Successfully merging this pull request may close these issues.

6 participants

@giancarloromeo @wvangeit @GitHK @pcrespov @odeimaiz @sanderegg