-
Notifications
You must be signed in to change notification settings - Fork 32
✨ [Frontend] Event-driven PATCH trigger #8154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mergify
merged 77 commits into
ITISFoundation:master
from
odeimaiz:feature/event-driven-patches
Jul 27, 2025
Merged
✨ [Frontend] Event-driven PATCH trigger #8154
mergify
merged 77 commits into
ITISFoundation:master
from
odeimaiz:feature/event-driven-patches
Jul 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parc-simcore into feature/event-driven-patches
…parc-simcore into feature/event-driven-patches
Member
Author
|
@mergify queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 3ecd9de |
|
matusdrobuliak66
approved these changes
Jul 27, 2025
Collaborator
matusdrobuliak66
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
pcrespov
approved these changes
Jul 27, 2025
giancarloromeo
approved these changes
Jul 28, 2025
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🤖-automerge
marks PR as ready to be merged for Mergify
a:frontend
issue affecting the front-end (area group)
t:enhancement
Improvement or request on an existing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



What do these changes do?
This PR changes the timing of when the PATCHES to the backend are triggered.
We currently, every 3", serialize and deep-compare the frontend's current study JSON state to the one in the backend (the frontend keeps a copy of it). This
diffis curated and the backend updates its state. The drawbacks of this approach are that:Now, and only when
WEBSERVER_REALTIME_COLLABORATIONis enabled, we move to an event-driven patching system, where we listen to changes in the study and trigger the patching process. For now, no changes in the patching process: we still compute the diff and send it to the backend. Since we don't want to overload the backend with patches that can happen in chain, there is a throttling mechanism that will wait 500ms and then patch. Even though the frontend still doesn't send the atomic patch data, it does generate the patch model proposed in here and we might eventually move there.We listen to changes on
Demos:
Changes: study.name, study.workbench.$nodeId.[label, inputNodes, bootOptions] and study.ui.workbench.$nodeId.position

Changes: study.workbench.$nodeId.inputs

Changes: Study.ui.workbench.$nodeId.marker and Study.ui.annotations/$annotationId

Related issue/s
How to test
Dev-ops