Skip to content

🐛 [Frontend] Conversations: fixes #8168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 28, 2025
Merged

🐛 [Frontend] Conversations: fixes #8168

merged 5 commits into from
Jul 28, 2025

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jul 28, 2025 •
edited
Loading

What do these changes do?

Fixes:

  • Remove temporary conversation page
  • Update number of messages when they go down to 0

Fixed

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz self-assigned this Jul 28, 2025
@odeimaiz odeimaiz added this to the Engage milestone Jul 28, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Jul 28, 2025
@odeimaiz odeimaiz marked this pull request as ready for review July 28, 2025 15:05
@odeimaiz odeimaiz added bug buggy, it does not work as expected and removed t:enhancement Improvement or request on an existing feature labels Jul 28, 2025
@odeimaiz odeimaiz requested a review from Copilot July 28, 2025 15:05
Copilot AI reviewed Jul 28, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR contains bug fixes for the Frontend Conversations feature. The changes address various issues including variable naming consistency, annotation serialization, conversation handling, and error handling improvements.

  • Improves variable naming for clarity and consistency
  • Fixes annotation serialization by ensuring all types include color attribute
  • Enhances conversation UI handling for temporary conversation pages
  • Updates operation names for consistency with backend expectations

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
WorkbenchUI.js Renames variable from tempNodeUI to dashedNodeUI for better clarity
Annotation.js Ensures all annotation types include color attribute in serialization
Conversations.js Adds logic to handle temporary conversation pages and prevents errors when removing buttons
Workbench.js Makes giveUniqueNameToNode method private by renaming to __giveUniqueNameToNode
StudyUI.js Changes operation from "delete" to "remove" for consistency
Study.js Improves error handling by restructuring conditional logic for node updates
Node.js Changes operation from "delete" to "remove" for consistency
Conversation.js Fixes message display logic and adds null check for load more button

@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label Jul 28, 2025
@odeimaiz
Copy link
Member Author

odeimaiz commented Jul 28, 2025

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Jul 28, 2025 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 9845835

pcrespov
pcrespov reviewed Jul 28, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

GitHK
GitHK approved these changes Jul 28, 2025
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that the backed should invert the order of the messages. It looks strange that the latest is on top

sanderegg
sanderegg reviewed Jul 28, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz
Copy link
Member Author

odeimaiz commented Jul 28, 2025

I guess that the backed should invert the order of the messages. It looks strange that the latest is on top

Done 👍

@odeimaiz
Copy link
Member Author

odeimaiz commented Jul 28, 2025

@mergify requeue

@mergify
Copy link
Contributor

mergify bot commented Jul 28, 2025

requeue

☑️ This pull request is already queued

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 28, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mergify mergify bot merged commit 9845835 into ITISFoundation:master Jul 28, 2025
60 checks passed
@odeimaiz odeimaiz deleted the fix/conversations branch July 28, 2025 16:42
@YuryHrytsuk YuryHrytsuk mentioned this pull request Jul 29, 2025
Closed
18 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
Closed
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcrespov pcrespov pcrespov left review comments

@sanderegg sanderegg sanderegg left review comments

Copilot code review Copilot Copilot left review comments

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@GitHK GitHK GitHK approved these changes

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

Assignees

@odeimaiz odeimaiz

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected

Projects

None yet

Milestone

Engage

Development

Successfully merging this pull request may close these issues.

5 participants

@odeimaiz @giancarloromeo @GitHK @pcrespov @sanderegg