node locking #8170
Merged
node locking #8170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
added
the
a:webserver
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8170 +/- ##
==========================================
+ Coverage 88.03% 88.04% +0.01%
==========================================
Files 1915 1912 -3
Lines 73834 73821 -13
Branches 1299 1300 +1
==========================================
- Hits 64997 64995 -2
+ Misses 8447 8435 -12
- Partials 390 391 +1
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
sanderegg
force-pushed
the
i1961/add-Node-lock
branch
3 times, most recently
from
fc7ed8a to
a4506cf
Compare
sanderegg
force-pushed
the
i1961/add-Node-lock
branch
from
4c23e76 to
1867e27
Compare
sanderegg
force-pushed
the
i1961/add-Node-lock
branch
from
73b345d to
5463dc2
Compare
sanderegg
force-pushed
the
i1961/add-Node-lock
branch
4 times, most recently
from
08f0057 to
9bbdb6b
Compare
11 tasks
sanderegg
force-pushed
the
i1961/add-Node-lock
branch
from
30097e9 to
1223c8b
Compare
Contributor
sanderegg
force-pushed
the
i1961/add-Node-lock
branch
2 times, most recently
from
4712889 to
37f4d75
Compare
sanderegg
force-pushed
the
i1961/add-Node-lock
branch
from
449db88 to
1412a03
Compare
sanderegg
force-pushed
the
i1961/add-Node-lock
branch
from
e56f6de to
1cec2bb
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR introduce a new
NodeShareStateobject that contains the lock state, which groups currently have that node and its current status. Note that currently there are no shareable services and the new flag for these collaborative services is not checked, therefore all services are locked when one user uses them.The websocket event
NodeUpdatedis extended with the additional information.Currently the information can also be retrieved via
GET /projects/{id}in the workbench subsection. NOTE that thatGET /projects/{id}/nodes/{id}does not return the node state as it should but only the dynamic service state probably due to historical reasons and missing updates.The new message data:
@odeimaiz note that in this case it is sadly still in snake casing. changing this implies many more changes and I am a bit reluctent on spending that time for it.
Also the
NodeUpdatedevent is emitted when a user starts a service and when a service completed stopping. Currently since thedynamic-scheduleractually bypasses all other backend services to communicate with the frontend it can lead to a problem.Related issue/s
How to test
Dev-ops