Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Aug 6, 2025

What do these changes do?

This pull request adds support for adding nodes in Real-Time Collaboration (RTC) mode. The changes focus on handling collaborative node creation and updates through improved serialization, event handling, and UI updates.

  • Refactors node creation, update asynchronous node metadata fetching and real-time node addition support
  • Implements throttled project document coming updates to handle concurrent modifications
  • Adds support for unknown/placeholder nodes during metadata loading

Next step:

  • Handle "unknown" node creation on clientB side

AddNodes

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz self-assigned this Aug 6, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Aug 6, 2025
@odeimaiz odeimaiz added this to the Voyager milestone Aug 6, 2025
@odeimaiz odeimaiz marked this pull request as ready for review August 14, 2025 10:24
@odeimaiz odeimaiz requested a review from Copilot August 14, 2025 10:25
…osparc-simcore into feature/render-unknown-service
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds support for adding nodes in Real-Time Collaboration (RTC) mode, enabling collaborative editing features in the frontend. The changes focus on handling collaborative node creation and updates through improved serialization, event handling, and UI updates.

  • Introduces asynchronous node metadata fetching and real-time node addition support
  • Implements throttled project document updates to handle concurrent modifications
  • Adds support for unknown/placeholder nodes during metadata loading

Reviewed Changes

Copilot reviewed 31 out of 31 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
services/static-webserver/client/source/class/osparc/workbench/WorkbenchUI.js Refactors node creation to use new addNode method and updates event listener names
services/static-webserver/client/source/class/osparc/workbench/NodeUI.js Major refactoring of node UI creation with new type system and metadata handling
services/static-webserver/client/source/class/osparc/data/model/Workbench.js Extensive changes to support async node creation and RTC patch handling
services/static-webserver/client/source/class/osparc/data/model/Node.js Refactors constructor and metadata handling for async loading
services/static-webserver/client/source/class/osparc/data/model/NodeUnknown.js New class for handling nodes with unknown metadata
services/static-webserver/client/source/class/osparc/desktop/StudyEditor.js Implements throttled project document updates for RTC
Multiple other files Various supporting changes including method renames, UI updates, and bug fixes

@sonarqubecloud
Copy link

@odeimaiz odeimaiz changed the title ✨ [Frontend] RTC: Support add nodes ✨ [Frontend] RTC: Support for adding nodes Aug 14, 2025
@odeimaiz
Copy link
Member Author

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Aug 14, 2025

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • label=🤖-automerge
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
      • any of: [🛡 GitHub branch protection]
        • check-success = SonarCloud Code Analysis
        • check-neutral = SonarCloud Code Analysis
        • check-skipped = SonarCloud Code Analysis
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@odeimaiz odeimaiz merged commit f00ff11 into ITISFoundation:master Aug 14, 2025
58 checks passed
@odeimaiz odeimaiz deleted the feature/render-unknown-service branch August 14, 2025 11:38
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 2, 2025
61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants