✨ [Frontend] RTC: Support for adding nodes #8196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
…osparc-simcore into feature/render-unknown-service
…osparc-simcore into feature/render-unknown-service
…osparc-simcore into feature/render-unknown-service
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for adding nodes in Real-Time Collaboration (RTC) mode, enabling collaborative editing features in the frontend. The changes focus on handling collaborative node creation and updates through improved serialization, event handling, and UI updates.
- Introduces asynchronous node metadata fetching and real-time node addition support
- Implements throttled project document updates to handle concurrent modifications
- Adds support for unknown/placeholder nodes during metadata loading
Reviewed Changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/workbench/WorkbenchUI.js | Refactors node creation to use new addNode method and updates event listener names |
| services/static-webserver/client/source/class/osparc/workbench/NodeUI.js | Major refactoring of node UI creation with new type system and metadata handling |
| services/static-webserver/client/source/class/osparc/data/model/Workbench.js | Extensive changes to support async node creation and RTC patch handling |
| services/static-webserver/client/source/class/osparc/data/model/Node.js | Refactors constructor and metadata handling for async loading |
| services/static-webserver/client/source/class/osparc/data/model/NodeUnknown.js | New class for handling nodes with unknown metadata |
| services/static-webserver/client/source/class/osparc/desktop/StudyEditor.js | Implements throttled project document updates for RTC |
| Multiple other files | Various supporting changes including method renames, UI updates, and bug fixes |
services/static-webserver/client/source/class/osparc/store/Services.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/data/model/Workbench.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/data/model/NodeUnknown.js
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/data/model/NodeUnknown.js
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/desktop/StudyEditor.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/desktop/StudyEditor.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/data/model/Workbench.js
Outdated
Show resolved
Hide resolved
…l/Workbench.js Co-authored-by: Copilot <[email protected]>
…osparc-simcore into feature/render-unknown-service
|
odeimaiz
requested review from
GitHK,
bisgaard-itis,
giancarloromeo,
matusdrobuliak66 and
sanderegg
odeimaiz
changed the title
giancarloromeo
approved these changes
Aug 14, 2025
Member
Author
|
@mergify queue |
Contributor
🟠 Waiting for conditions to match
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This pull request adds support for adding nodes in Real-Time Collaboration (RTC) mode. The changes focus on handling collaborative node creation and updates through improved serialization, event handling, and UI updates.
Next step:
Related issue/s
How to test
Dev-ops