-
Notifications
You must be signed in to change notification settings - Fork 32
✨👽️🗃️ Introduce api-server endpoint for deleting solver job assets (s3-data) #8203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨👽️🗃️ Introduce api-server endpoint for deleting solver job assets (s3-data) #8203
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8203 +/- ##
==========================================
- Coverage 88.12% 88.08% -0.05%
==========================================
Files 1855 1910 +55
Lines 71017 73492 +2475
Branches 1301 1301
==========================================
+ Hits 62585 64732 +2147
- Misses 8044 8372 +328
Partials 388 388
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
🧪 CI InsightsHere's what we observed from your CI run for 005c2d5. ✅ Passed Jobs With Interesting Signals
|
matusdrobuliak66
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please double check the ProjectPatch thing. this might hide a lot of projects...
Also I would strongly suggest to use assets everywhere for consistency.
Thanks!
packages/models-library/src/models_library/api_schemas_webserver/projects.py
Outdated
Show resolved
Hide resolved
packages/models-library/src/models_library/rpc/webserver/projects.py
Outdated
Show resolved
Hide resolved
..._postgres_database/migration/versions/5b998370916a_introduce_data_deleted_in_projects_to_.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/api/routes/solvers_jobs.py
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/services_http/storage.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/services_http/storage.py
Show resolved
Hide resolved
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
|
@Mergifyio queue |
🟠 Waiting for conditions to match
|
GitHK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I think you forgot something
packages/models-library/src/models_library/api_schemas_webserver/projects.py
Show resolved
Hide resolved
GitHK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|



What do these changes do?
projects_to_jobstable in the database.projects_to_jobstable in the db to add a new column for the flag.@wvangeit this is probably relevant for you. With this in, it would be very easy to clean up S3-data associated with function jobs without deleting the jobs nor the functions themselves.
Related issue/s
How to test
Dev-ops