-
Notifications
You must be signed in to change notification settings - Fork 32
✨👽️🗃️ Introduce api-server endpoint for deleting solver job assets (s3-data) #8203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mrnicegyu11
merged 64 commits into
ITISFoundation:master
from
bisgaard-itis:219-webserver-part-for-deleting-job-data
Aug 15, 2025
Merged
Changes from 62 commits
Commits
Show all changes
64 commits
Select commit
Hold shift + click to select a range
7354c1e
add skeleton endpoint for solver jobs
bisgaard-itis a719805
add 'hidden' to project patch model
bisgaard-itis 7eeb160
add method for deleting jobs assets to JobService
bisgaard-itis 1dece17
fix job_service method
bisgaard-itis 7ad678a
first attempt at introducing 'get' method for project_marked_as_job
bisgaard-itis d3e09bf
add client method
bisgaard-itis d017714
add tests for get_project_marked_as_job method
bisgaard-itis a3f4692
explicit is better than implicit
bisgaard-itis a56062b
first attempt to do migration
bisgaard-itis 28588af
update migration script
bisgaard-itis 10ed5ba
modify tests and repo-service layers to acommodate storage_data_deleted
bisgaard-itis 703bdf5
add test for storage_data_deletted
bisgaard-itis d25638b
fix tests
bisgaard-itis daf9445
ensure storage_data_deleted_column can be updated
bisgaard-itis 25364f7
minor changes in api-server
bisgaard-itis 175ff33
Merge branch '219-delete-job-s3-data' into 219-webserver-part-for-del…
bisgaard-itis 562ebff
polish endspoint exposed in api-server
bisgaard-itis 6cecc0f
only require project_uuid to get project_marked as job
bisgaard-itis 07c7fbc
create domain model for jobs
bisgaard-itis ffce9cd
Revert "create domain model for jobs"
bisgaard-itis 0425414
Revert "only require project_uuid to get project_marked as job"
bisgaard-itis 9a01f15
add method for getting job which also checks parent resource
bisgaard-itis 68156b5
minor fix
bisgaard-itis 1cde55b
Merge branch 'master' into 219-webserver-part-for-deleting-job-data
bisgaard-itis 88bbe32
minor bugfix
bisgaard-itis b3165d1
add return type in WbApiRpcClient.get_project_marked_as_job
bisgaard-itis 36fd97b
fix webserver rpc mocks
bisgaard-itis 9bd8349
fix fixture in api-server unit tests
bisgaard-itis ee3ab9d
fix pylint tests
bisgaard-itis dbe3c0a
add tests for get_project_marked_as_job
bisgaard-itis af2a969
add unit tests for get_job_method
bisgaard-itis 34e7622
first attempt at adding unittest for entire api-server endpoint
bisgaard-itis 88be256
improve unittest of delete assets endpoint
bisgaard-itis 23da7db
Merge branch 'master' into 219-webserver-part-for-deleting-job-data
bisgaard-itis 6a09516
refuse to start solver job whose assets are missing
bisgaard-itis 987186a
Merge branch 'master' into 219-webserver-part-for-deleting-job-data
bisgaard-itis da5e80e
update openapi specs
bisgaard-itis 58cdb7e
minor fix
bisgaard-itis 0258422
raise instead of returning
bisgaard-itis b357b0a
fix tests
bisgaard-itis 30e8046
fix all tests in test_api_solver_jobs.py
bisgaard-itis 77ceacb
add test for checking new status code when starting job
bisgaard-itis f60d19b
cosmetic improvement
bisgaard-itis d1eca27
cleanup unused fixture
bisgaard-itis 6577ac7
cosmetic fix
bisgaard-itis d8c3375
@GitHK dont mis bool and None
bisgaard-itis 6e10f40
update openapi specs
bisgaard-itis 749b33f
change published version in new endpoint
bisgaard-itis 5e7d878
services/api-server version: 0.11.0 → 0.12.0
bisgaard-itis 92b8f6b
update openapi specs
bisgaard-itis 54d3a55
Merge branch 'master' into 219-webserver-part-for-deleting-job-data
bisgaard-itis e455fa0
Merge branch 'master' into 219-webserver-part-for-deleting-job-data
bisgaard-itis 2edeae9
add check that assets are available when getting job outputs
bisgaard-itis 4d5ba93
add test that 409 is returned when no assets available
bisgaard-itis 9eb4da5
make patch input schema nullable
bisgaard-itis 10db20e
update openapi specs
bisgaard-itis d005fa4
storage_data_deleted -> storage_assets_deleted
bisgaard-itis 9ec50f5
use consistent naming
bisgaard-itis ae8940c
@sanderegg int -> UserID
bisgaard-itis c6d6681
fixes
bisgaard-itis 0216e59
Merge branch 'master' into 219-webserver-part-for-deleting-job-data
bisgaard-itis 4fed7f3
Merge branch 'master' into 219-webserver-part-for-deleting-job-data
bisgaard-itis bf41cfb
storage_data_deleted -> storage_assets_deleted
bisgaard-itis 005c2d5
Merge branch 'master' into 219-webserver-part-for-deleting-job-data
bisgaard-itis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
...stgres_database/migration/versions/5b998370916a_introduce_data_deleted_in_projects_to_.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| """introduce data_deleted in projects_to_jobs table | ||
|
|
||
| Revision ID: 5b998370916a | ||
| Revises: 5679165336c8 | ||
| Create Date: 2025-08-11 13:58:38.424398+00:00 | ||
|
|
||
| """ | ||
|
|
||
| import sqlalchemy as sa | ||
| from alembic import op | ||
|
|
||
| # revision identifiers, used by Alembic. | ||
| revision = "5b998370916a" | ||
| down_revision = "5679165336c8" | ||
| branch_labels = None | ||
| depends_on = None | ||
|
|
||
|
|
||
| def upgrade(): | ||
| # ### commands auto generated by Alembic - please adjust! ### | ||
| op.add_column( | ||
| "projects_to_jobs", | ||
| sa.Column("storage_assets_deleted", sa.Boolean(), nullable=True), | ||
| ) | ||
|
|
||
| op.execute("UPDATE projects_to_jobs SET storage_assets_deleted = false") | ||
|
|
||
| op.alter_column( | ||
| "projects_to_jobs", | ||
| "storage_assets_deleted", | ||
| existing_type=sa.BOOLEAN(), | ||
| nullable=False, | ||
| ) | ||
| # ### end Alembic commands ### | ||
|
|
||
|
|
||
| def downgrade(): | ||
| # ### commands auto generated by Alembic - please adjust! ### | ||
| op.drop_column("projects_to_jobs", "storage_assets_deleted") | ||
| # ### end Alembic commands ### |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 0.11.0 | ||
| 0.12.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.