Skip to content

Conversation

@matusdrobuliak66
Copy link
Collaborator

Refactors group notification to use a dedicated API for fetching project group permissions, enhancing consistency and maintainability. Removes reliance on direct access to project permission structures.

What do these changes do?

🐛 Fix bug when notifying users based on wrong access rights

Related issue/s

How to test

Dev-ops

Refactors group notification to use a dedicated API for fetching project group permissions, enhancing consistency and maintainability. Removes reliance on direct access to project permission structures.
@matusdrobuliak66 matusdrobuliak66 self-assigned this Aug 12, 2025
@matusdrobuliak66 matusdrobuliak66 added bug buggy, it does not work as expected a:webserver webserver's codebase. Assigning the area is particularly useful for bugs labels Aug 12, 2025
@matusdrobuliak66 matusdrobuliak66 added this to the Voyager milestone Aug 12, 2025
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review August 12, 2025 11:50
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.32%. Comparing base (506ec7c) to head (289544c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8207      +/-   ##
==========================================
- Coverage   87.37%   85.32%   -2.06%     
==========================================
  Files        1907      738    -1169     
  Lines       73279    33776   -39503     
  Branches     1301      176    -1125     
==========================================
- Hits        64031    28818   -35213     
+ Misses       8861     4900    -3961     
+ Partials      387       58     -329     
Flag Coverage Δ
integrationtests 64.28% <100.00%> (+3.66%) ⬆️
unittests 87.40% <100.00%> (+0.82%) ⬆️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.16% <ø> (-7.89%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 77.92% <ø> (-7.45%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 87.23% <ø> (ø)
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 88.15% <100.00%> (-0.02%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 506ec7c...289544c. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify
Copy link
Contributor

mergify bot commented Aug 12, 2025

🧪 CI Insights

Here's what we observed from your CI run for 289544c.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on base branch Retries 🔍 CI Insights 📄 Logs
CI [sys] e2e (3.11, 14, ubuntu-24.04) Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View
system-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) August 12, 2025 12:34
Copy link
Contributor

@giancarloromeo giancarloromeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🚀

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 💯

@matusdrobuliak66 matusdrobuliak66 merged commit 19e3d7a into ITISFoundation:master Aug 12, 2025
93 of 95 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 2, 2025
61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:webserver webserver's codebase. Assigning the area is particularly useful for bugs bug buggy, it does not work as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Old access_rights from projects table still referenced

3 participants