Skip to content

🐛 Fix bug when notifying users based on wrong access rights #8207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025
Merged

🐛 Fix bug when notifying users based on wrong access rights #8207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions services/web/server/src/simcore_service_webserver/projects/_groups_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,3 +252,20 @@ async def create_project_group_without_checking_permissions(
write=write,
delete=delete,
)


async def list_project_groups_by_project_without_checking_permissions(
app: web.Application,
*,
project_id: ProjectID,
) -> list[ProjectGroupGet]:
project_groups_db: list[ProjectGroupGetDB] = (
await _groups_repository.list_project_groups(app=app, project_id=project_id)
)

project_groups_api: list[ProjectGroupGet] = [
ProjectGroupGet.model_validate(group.model_dump())
for group in project_groups_db
]

return project_groups_api
18 changes: 12 additions & 6 deletions services/web/server/src/simcore_service_webserver/projects/_projects_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
import datetime
import logging
from collections import defaultdict
from collections.abc import Generator, Iterable
from collections.abc import Iterable
from contextlib import suppress
from decimal import Decimal
from pprint import pformat
Expand Down Expand Up @@ -130,6 +130,7 @@
from ..workspaces import _workspaces_repository as workspaces_workspaces_repository
from . import (
_crud_api_delete,
_groups_service,
_nodes_service,
_projects_nodes_repository,
_projects_repository,
Expand Down Expand Up @@ -2107,9 +2108,13 @@ async def notify_project_state_update(
message=message,
)
else:
rooms_to_notify: Generator[GroupID, None, None] = (
gid for gid, rights in project["accessRights"].items() if rights["read"]
project_group_get_list = await _groups_service.list_project_groups_by_project_without_checking_permissions(
app, project_id=project["uuid"]
)

rooms_to_notify = [
item.gid for item in project_group_get_list if item.read is True
]
for room in rooms_to_notify:
await send_message_to_standard_group(app, group_id=room, message=message)

Expand All @@ -2123,9 +2128,10 @@ async def notify_project_node_update(
if await is_project_hidden(app, ProjectID(project["uuid"])):
return

rooms_to_notify: list[GroupID] = [
gid for gid, rights in project["accessRights"].items() if rights["read"]
]
project_group_get_list = await _groups_service.list_project_groups_by_project_without_checking_permissions(
app, project_id=project["uuid"]
)
rooms_to_notify = [item.gid for item in project_group_get_list if item.read is True]

message = SocketMessageDict(
event_type=SOCKET_IO_NODE_UPDATED_EVENT,
Expand Down
Loading