Skip to content

Conversation

@matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Aug 12, 2025

Guards document update notifications with a configuration check to ensure updates are sent only when realtime collaboration is enabled. Prevents unnecessary operations and aligns with feature toggling.

What do these changes do?

  • ♻️ Adds feature flag check for realtime collaboration Project Document updates

Related issue/s

How to test

Dev-ops

Guards document update notifications with a configuration check
to ensure updates are sent only when realtime collaboration is enabled.
Prevents unnecessary operations and aligns with feature toggling.
@matusdrobuliak66 matusdrobuliak66 self-assigned this Aug 12, 2025
@matusdrobuliak66 matusdrobuliak66 added this to the Voyager milestone Aug 12, 2025
@matusdrobuliak66 matusdrobuliak66 added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Aug 12, 2025
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review August 12, 2025 13:30
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) August 12, 2025 13:30
@codecov
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.41%. Comparing base (8548b0e) to head (c0c3163).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8209      +/-   ##
==========================================
- Coverage   87.61%   85.41%   -2.20%     
==========================================
  Files        1910      738    -1172     
  Lines       73360    33785   -39575     
  Branches     1301      176    -1125     
==========================================
- Hits        64273    28859   -35414     
+ Misses       8714     4868    -3846     
+ Partials      373       58     -315     
Flag Coverage Δ
integrationtests 64.33% <33.33%> (+0.67%) ⬆️
unittests 87.40% <100.00%> (+0.68%) ⬆️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 76.98% <ø> (+11.59%) ⬆️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.34% <ø> (-12.58%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 87.23% <ø> (-2.89%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 88.17% <100.00%> (-0.02%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8548b0e...c0c3163. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify
Copy link
Contributor

mergify bot commented Aug 12, 2025

🧪 CI Insights

Here's what we observed from your CI run for c0c3163.

🟢 All jobs passed!

But CI Insights is watching 👀

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@sonarqubecloud
Copy link

@matusdrobuliak66 matusdrobuliak66 merged commit 64d6099 into ITISFoundation:master Aug 13, 2025
93 of 95 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 2, 2025
61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants