Skip to content

♻️ Adds feature flag check for realtime collaboration Project Document updates #8209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 13, 2025
Merged

♻️ Adds feature flag check for realtime collaboration Project Document updates #8209

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f7edeb
Adds feature flag check for realtime collaboration updates
matusdrobuliak66 Aug 12, 2025
c92eb97
fix test
matusdrobuliak66 Aug 13, 2025
0dceb0b
fix test
matusdrobuliak66 Aug 13, 2025
c0c3163
Merge branch 'master' into enable-project-documents-based-on-env-var
matusdrobuliak66 Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 17 additions & 12 deletions services/web/server/src/simcore_service_webserver/projects/_projects_repository_legacy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@
from tenacity.asyncio import AsyncRetrying
from tenacity.retry import retry_if_exception_type

from ..application_settings import get_application_settings
from ..models import ClientSessionID
from ..utils import now_str
from ._comments_repository import (
Expand Down Expand Up @@ -957,19 +958,23 @@ async def _update_project_workbench_with_lock_and_notify(
allow_workbench_changes=allow_workbench_changes,
)

(
project_document,
document_version,
) = await create_project_document_and_increment_version(self._app, project_uuid)
app_settings = get_application_settings(self._app)
if app_settings.WEBSERVER_REALTIME_COLLABORATION is not None:
(
project_document,
document_version,
) = await create_project_document_and_increment_version(
self._app, project_uuid
)

await notify_project_document_updated(
app=self._app,
project_id=project_uuid,
user_primary_gid=user_primary_gid,
client_session_id=client_session_id,
version=document_version,
document=project_document,
)
await notify_project_document_updated(
app=self._app,
project_id=project_uuid,
user_primary_gid=user_primary_gid,
client_session_id=client_session_id,
version=document_version,
document=project_document,
)
return updated_project, changed_entries

async def _update_project_workbench(
Expand Down
26 changes: 14 additions & 12 deletions services/web/server/src/simcore_service_webserver/projects/_projects_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,18 +205,20 @@ async def patch_project_and_notify_users(
new_partial_project_data=patch_project_data,
)

(
project_document,
document_version,
) = await create_project_document_and_increment_version(app, project_uuid)
await notify_project_document_updated(
app=app,
project_id=project_uuid,
user_primary_gid=user_primary_gid,
client_session_id=client_session_id,
version=document_version,
document=project_document,
)
app_settings = get_application_settings(app)
if app_settings.WEBSERVER_REALTIME_COLLABORATION is not None:
(
project_document,
document_version,
) = await create_project_document_and_increment_version(app, project_uuid)
await notify_project_document_updated(
app=app,
project_id=project_uuid,
user_primary_gid=user_primary_gid,
client_session_id=client_session_id,
version=document_version,
document=project_document,
)


def _is_node_dynamic(node_key: str) -> bool:
Expand Down
Loading