β¨ First iteration backend for support center (ποΈ) #8212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Reportβ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8212 +/- ##
==========================================
+ Coverage 88.09% 89.80% +1.71%
==========================================
Files 1911 1625 -286
Lines 73543 64243 -9300
Branches 1299 640 -659
==========================================
- Hits 64787 57695 -7092
+ Misses 8366 6379 -1987
+ Partials 390 169 -221
Continue to review full report in Codecov by Sentry.
π New features to boost your workflow:
|
Contributor
π§ͺ CI InsightsHere's what we observed from your CI run for 8a31d1a. β Passed Jobs With Interesting Signals
|
Allows support conversations and messages to be created, updated, and deleted without requiring a project ID. Prevents unnecessary notifications for support conversations by skipping events when no project ID is present. Improves access control checks and context handling for support-type conversations. Enhances code clarity and robustness for support workflows.
Moves REST endpoints for conversation messages into a separate controller for improved modularity and maintainability. Refactors logic to better support support-type conversations, removing unnecessary project_id handling and redundant code. Enhances separation between conversation and message operations.
Replaces ad-hoc exception handling with a centralized decorator, introducing custom exceptions for unsupported conversation types. Improves code clarity, reduces duplication, and ensures more consistent HTTP error responses across conversation APIs.
Enables richer data storage for conversations by introducing a JSONB field for extra context. Links products to support groups, improving flexibility in product support management via a new nullable foreign key. Facilitates future enhancements in conversation and product handling.
matusdrobuliak66
added
the
a:webserver
Introduces new RESTful routes and OpenAPI specs to manage conversations and their messages, supporting create, list, update, delete, and retrieve operations. Refactors common path parameter logic for improved code reuse. Extends conversation types and schema definitions to enable more flexible conversational features.
Updates parameter names from 'type' to 'type_' in conversation-related functions to avoid shadowing built-in names and improve code readability.
Updates comments to more accurately describe API entrypoints, improving readability and maintainability by aligning section headers with their actual functionality.
Replaces ambiguous parameter name with a more explicit one to prevent confusion with the Python built-in type and improve code clarity.
Replaces use of 'in' operator with SQLAlchemy's 'in_' method to ensure correct filtering of conversation types in queries. Prevents potential logical errors and improves query reliability.
Clarifies validation error when a non-support conversation type is provided, making the exception message more descriptive for better debugging and user feedback.
Introduces the SUPPORT value to conversation types and updates REST API error handling for unsupported types. Renames REST controller modules for consistency and registers their routes in the plugin. Adds comprehensive unit tests for conversation endpoints, covering access control, validation, pagination, and error handling. Facilitates future extension of conversation types and improves API reliability. Relates to ITISFoundation/private-issues#51
matusdrobuliak66
requested review from
GitHK,
giancarloromeo,
pcrespov and
sanderegg
as code owners
matusdrobuliak66
changed the title
GitHK
approved these changes
Aug 18, 2025
services/web/server/src/simcore_service_webserver/conversations/_controller/__init__.py
Show resolved
Hide resolved
services/web/server/tests/unit/with_dbs/04/conversations/__init__.py
Outdated
Show resolved
Hide resolved
Contributor
bisgaard-itis
left a comment
bisgaard-itis
left a comment
There was a problem hiding this comment.
Thanks a lot for the effort. Just a few suggestions from my side
services/web/server/src/simcore_service_webserver/api/v0/openapi.yaml
Outdated
Show resolved
Hide resolved
sanderegg
approved these changes
Aug 18, 2025
packages/models-library/src/models_library/api_schemas_webserver/conversations.py
Show resolved
Hide resolved
Switches to using a query parameter utility for improved validation and simplifies endpoint signatures. Updates OpenAPI spec to clarify request body requirements and relaxes query param constraints to offer greater flexibility in API usage.
Collaborator
Author
|
@mergify queue |
Contributor
π Waiting for conditions to match
|
matusdrobuliak66
added
the
π€-automerge
|
matusdrobuliak66
merged commit 133458b
into
ITISFoundation:master
93 of 95 checks passed
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
/conversationsand/conversations/<id>/messagesendpoints with focus onSUPPORTtypeNext steps:
Related issue/s
How to test
services/web/server/tests/unit/with_dbs/04/conversations/test_conversations_rest.pyservices/web/server/tests/unit/with_dbs/04/conversations/test_conversations_messages_rest.pyDev-ops