-
Notifications
You must be signed in to change notification settings - Fork 32
♻️ Refactor job_service and function_job_service in api-server before introducing celery worker
#8222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Refactor job_service and function_job_service in api-server before introducing celery worker
#8222
Conversation
🧪 CI InsightsHere's what we observed from your CI run for 90e9b2a. ✅ Passed Jobs With Interesting Signals
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8222 +/- ##
===========================================
- Coverage 87.79% 69.35% -18.44%
===========================================
Files 1868 857 -1011
Lines 72091 38487 -33604
Branches 1300 175 -1125
===========================================
- Hits 63289 26692 -36597
- Misses 8411 11738 +3327
+ Partials 391 57 -334
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
job_service in api-server before introducing celery workerjob_service and function_job_service in api-server before introducing celery worker
matusdrobuliak66
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful to look at 🤩
services/api-server/src/simcore_service_api_server/models/schemas/jobs.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/services_http/jobs.py
Outdated
Show resolved
Hide resolved
|
wvangeit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @bisgaard-itis
|
force merged upon request @bisgaard-itis |



What do these changes do?
JobServiceandFunctionJobServicerespectively in such a way that methods within those services can be run as jobs in celery.SolverServicewas dependent on theSolverJobService, but that's the wrong way around. I have resolved these issues so that the "jobs" services depend on their parents. This was required to complete the refactoring described above.Related issue/s
How to test
Dev-ops