🐛 [Frontend] Fix: start dynamic services #8224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
bug
odeimaiz
requested review from
GitHK,
bisgaard-itis,
Copilot,
giancarloromeo,
matusdrobuliak66 and
sanderegg
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with starting dynamic services in the frontend where a race condition was preventing proper initialization. The fix ensures that the progress sequence is created only after the node metadata is available.
- Moved progress sequence initialization from constructor to a property apply method
- Added conditional logic to handle cases where metadata may not be immediately available
- Implemented a listener to defer initialization until metadata becomes available
services/static-webserver/client/source/class/osparc/data/model/NodeStatus.js
Show resolved
Hide resolved
Member
Author
|
@mergify queue |
Contributor
🛑 Configuration not compatible with a branch protection settingThe branch protection setting |
GitHK
approved these changes
Aug 18, 2025
matusdrobuliak66
approved these changes
Aug 18, 2025
|
Contributor
🧪 CI InsightsHere's what we observed from your CI run for 089abbb. ✅ Passed Jobs With Interesting Signals
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Spotted by @sanderegg
This PR fixes the starting of dynamic services.
Notice the correct positioning and no errors popping up:
Related issue/s
How to test
Dev-ops