Skip to content

✨ Adds RPC interface for containers routes #8227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Sep 1, 2025
Merged

✨ Adds RPC interface for containers routes #8227

merged 32 commits into from
Sep 1, 2025

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Aug 18, 2025 •
edited
Loading

What do these changes do?

Extras:

  • ♻️ aligned docstring between RPC and HTTP interfaces to be the same

Extends the dynamic-sidecar's RPC interface to support the following:

This completes the migration to RPC of the entire http interface on the dynamic-sidecar

Related issue/s

How to test

Dev-ops

@GitHK GitHK self-assigned this Aug 18, 2025
@GitHK GitHK added the a:dynamic-sidecar dynamic-sidecar service label Aug 18, 2025
@GitHK GitHK added this to the Voyager milestone Aug 18, 2025
@codecov
Copy link

codecov bot commented Aug 18, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 76.42586% with 62 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.73%. Comparing base (1df610c) to head (90569a3).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8227      +/-   ##
==========================================
- Coverage   87.94%   87.73%   -0.22%     
==========================================
  Files        1930     1508     -422     
  Lines       74827    62363   -12464     
  Branches     1309      656     -653     
==========================================
- Hits        65808    54714   -11094     
+ Misses       8627     7418    -1209     
+ Partials      392      231     -161
Flag Coverage Δ
integrationtests 64.11% <37.79%> (-0.07%) ⬇️
unittests 86.12% <76.42%> (-0.47%) ⬇️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 71.19% <0.00%> (-0.55%) ⬇️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.03% <ø> (ø)
agent 93.53% <ø> (ø)
api_server 92.73% <ø> (ø)
autoscaling 95.90% <ø> (ø)
catalog 92.34% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 91.81% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 75.81% <ø> (-0.09%) ⬇️
director_v2 90.89% <ø> (-0.06%) ⬇️
dynamic_scheduler 96.27% <ø> (ø)
dynamic_sidecar 90.46% <96.17%> (+0.08%) ⬆️
efs_guardian 89.62% <ø> (ø)
invitations 91.44% <ø> (ø)
payments 92.61% <ø> (ø)
resource_usage_tracker 91.76% <ø> (-0.06%) ⬇️
storage 86.49% <ø> (-0.13%) ⬇️
webclient ∅ <ø> (∅)
webserver 88.03% <ø> (-0.03%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1df610c...90569a3. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for 90569a3.

🟢 All jobs passed!

But CI Insights is watching 👀

@GitHK GitHK changed the title ✨ Adds RPC interface for containers/ports routes ✨ Adds RPC interface for containers/ports and containers/{id}/networks routes Aug 28, 2025
@GitHK GitHK changed the title ✨ Adds RPC interface for containers/ports and containers/{id}/networks routes ✨ Adds RPC interface for containers routes Aug 28, 2025
@GitHK GitHK mentioned this pull request Aug 29, 2025
Open
@GitHK GitHK requested a review from Copilot August 29, 2025 10:36
Copilot AI reviewed Aug 29, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds RPC interfaces for the containers routes in the dynamic-sidecar service, completing the migration from HTTP to RPC communication. The changes align the docstrings between RPC and HTTP interfaces and extend the dynamic-sidecar's RPC interface to support various container operations.

Key changes:

  • Implements RPC interfaces for container operations
  • Refactors REST endpoints to use service layer functions
  • Standardizes documentation format across interfaces

Reviewed Changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
services/dynamic-sidecar/tests/unit/api/rpc/test__container_extensions.py New comprehensive test suite for RPC container extension interfaces
services/dynamic-sidecar/tests/unit/api/rest/test_containers.py Updates imports and error message formats to align with new service layer
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/services/containers.py New service layer implementing core container operations logic
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/services/container_extensions.py New service layer for container extension operations
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/api/rpc/_containers_extension.py New RPC interface for container extensions
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/api/rpc/_containers.py Enhanced RPC interface with additional container operations
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/api/rest/containers_extension.py Refactored to use service layer functions
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/api/rest/containers.py Simplified by delegating to service layer
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/dynamic_sidecar/containers.py Client-side RPC interface for container operations
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/dynamic_sidecar/container_extensions.py Client-side RPC interface for container extensions
Comments suppressed due to low confidence (1)

services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/api/rest/disk.py:1

  • There is a spelling error in the docstring: 'forntend' should be 'frontend'.
from fastapi import APIRouter, status

@GitHK GitHK mentioned this pull request Aug 29, 2025
Closed
1 task
@GitHK GitHK marked this pull request as ready for review August 29, 2025 10:46
@GitHK GitHK requested a review from pcrespov as a code owner August 29, 2025 10:46
sanderegg
sanderegg approved these changes Aug 29, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pcrespov
pcrespov approved these changes Sep 1, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, i still do not see the hierarchical design we discussed a resource-oriented design has https://google.aip.dev/121

but i do not want to hold this PR anymore.

@GitHK GitHK added the 🤖-automerge marks PR as ready to be merged for Mergify label Sep 1, 2025
@GitHK
Copy link
Contributor Author

GitHK commented Sep 1, 2025

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2025 •
edited
Loading

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
      • any of: [🛡 GitHub branch protection]
        • check-success = SonarCloud Code Analysis
        • check-neutral = SonarCloud Code Analysis
        • check-skipped = SonarCloud Code Analysis
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@GitHK GitHK merged commit 5affe86 into ITISFoundation:master Sep 1, 2025
93 of 95 checks passed
@GitHK GitHK deleted the pr-osparc-dy-sidecar-ports-migrate branch September 1, 2025 10:38
This was referenced Sep 2, 2025
Closed
Closed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 18, 2025
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg sanderegg approved these changes

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@GitHK GitHK

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:dynamic-sidecar dynamic-sidecar service

Projects

None yet

Milestone

Voyager

Development

Successfully merging this pull request may close these issues.

3 participants

@GitHK @pcrespov @sanderegg