-
Notifications
You must be signed in to change notification settings - Fork 32
🐛Refreshing shall renew the socket #8228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛Refreshing shall renew the socket #8228
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8228 +/- ##
==========================================
- Coverage 88.05% 85.35% -2.71%
==========================================
Files 1915 742 -1173
Lines 73880 34182 -39698
Branches 1300 175 -1125
==========================================
- Hits 65056 29175 -35881
+ Misses 8432 4950 -3482
+ Partials 392 57 -335
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
🧪 CI InsightsHere's what we observed from your CI run for a19fb27. ✅ Passed Jobs With Interesting Signals
|
eed0530 to
33df8d1
Compare
33df8d1 to
eaa2ff2
Compare
odeimaiz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful, thanks!
matusdrobuliak66
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool thanks
GitHK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
services/web/server/src/simcore_service_webserver/projects/_projects_service.py
Outdated
Show resolved
Hide resolved
|
@mergify queue |
🛑 Configuration not compatible with a branch protection settingThe branch protection setting |
|



What do these changes do?
Fix the issue where when the maximal amount of session was reached, refreshing a tab would throw the user out of the project
driving tests:
test_refreshing_tab_of_opened_project_multiple_userstest_closing_and_reopening_tab_of_opened_project_multiple_usersRelated issue/s
How to test
Dev-ops