-
Notifications
You must be signed in to change notification settings - Fork 32
🎨 instrument storage and director httpx client (opentelemetry) #8234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 instrument storage and director httpx client (opentelemetry) #8234
Conversation
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8234 +/- ##
==========================================
- Coverage 88.01% 87.91% -0.11%
==========================================
Files 1916 1492 -424
Lines 74046 61576 -12470
Branches 1300 651 -649
==========================================
- Hits 65172 54132 -11040
+ Misses 8482 7213 -1269
+ Partials 392 231 -161
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
bisgaard-itis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Thanks a lot. I suggest to check if this actually propagates the traces you want. Just to be sure there are no other things missing 🤞🏻
🧪 CI InsightsHere's what we observed from your CI run for f4bba45. ✅ Passed Jobs With Interesting Signals
|
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍



What do these changes do?
Instruments the httpx clients of director-v0 and storage. This enables us to add internals of the
registry(which since major version 3 supports opentelemetry) to our tracing, allowing us to investigate e.g. slow calls to"/v0/catalog/services/-/latest"Co-Authered with @bisgaard-itis , thx!
Related issue/s
How to test
Dev-ops