Skip to content

Conversation

@mrnicegyu11
Copy link
Member

What do these changes do?

Instruments the httpx clients of director-v0 and storage. This enables us to add internals of the registry (which since major version 3 supports opentelemetry) to our tracing, allowing us to investigate e.g. slow calls to "/v0/catalog/services/-/latest"

Co-Authered with @bisgaard-itis , thx!

Related issue/s

How to test

Dev-ops

@mrnicegyu11 mrnicegyu11 added this to the Voyager milestone Aug 19, 2025
@mrnicegyu11 mrnicegyu11 self-assigned this Aug 19, 2025
@mrnicegyu11 mrnicegyu11 added the a:storage issue related to storage service label Aug 19, 2025
@mrnicegyu11 mrnicegyu11 added the a:director issue related with the director service label Aug 19, 2025
@mrnicegyu11 mrnicegyu11 requested a review from GitHK as a code owner August 19, 2025 14:21
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.91%. Comparing base (d296fbe) to head (f4bba45).
⚠️ Report is 21 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8234      +/-   ##
==========================================
- Coverage   88.01%   87.91%   -0.11%     
==========================================
  Files        1916     1492     -424     
  Lines       74046    61576   -12470     
  Branches     1300      651     -649     
==========================================
- Hits        65172    54132   -11040     
+ Misses       8482     7213    -1269     
+ Partials      392      231     -161     
Flag Coverage Δ
integrationtests 64.05% <ø> (+0.07%) ⬆️
unittests 86.28% <20.00%> (-0.39%) ⬇️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 71.82% <0.00%> (-0.02%) ⬇️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.03% <ø> (+0.05%) ⬆️
agent 93.90% <ø> (ø)
api_server 92.84% <ø> (ø)
autoscaling 95.89% <ø> (ø)
catalog 92.34% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 91.81% <ø> (-0.34%) ⬇️
datcore_adapter 97.94% <ø> (ø)
director 76.14% <ø> (ø)
director_v2 90.98% <ø> (+0.05%) ⬆️
dynamic_scheduler 96.27% <ø> (ø)
dynamic_sidecar 90.05% <ø> (ø)
efs_guardian 89.62% <ø> (ø)
invitations 91.44% <ø> (ø)
payments 92.61% <ø> (ø)
resource_usage_tracker 92.24% <ø> (+0.10%) ⬆️
storage 86.34% <100.00%> (-0.13%) ⬇️
webclient ∅ <ø> (∅)
webserver 88.10% <ø> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d296fbe...f4bba45. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks a lot. I suggest to check if this actually propagates the traces you want. Just to be sure there are no other things missing 🤞🏻

@mergify
Copy link
Contributor

mergify bot commented Aug 19, 2025

🧪 CI Insights

Here's what we observed from your CI run for f4bba45.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on base branch Retries 🔍 CI Insights 📄 Logs
CI [int] docker-api-proxy (3.11, ubuntu-24.04) Base branch is healthy, but retries were needed. Could be early signs of flakiness 👀 Healthy 1 View View
[unit] api-server (3.11, ubuntu-24.04) Base branch is healthy, but retries were needed. Could be early signs of flakiness 👀 Healthy 1 View View
[unit] datcore-adapter (3.11, ubuntu-24.04) Base branch is healthy, but retries were needed. Could be early signs of flakiness 👀 Healthy 1 View View
[unit] python-linting (3.12, ubuntu-24.04) Base branch is healthy, but retries were needed. Could be early signs of flakiness 👀 Healthy 1 View View
[unit] service-library (3.11, ubuntu-24.04) Base branch is healthy, but retries were needed. Could be early signs of flakiness 👀 Healthy 1 View View
integration-tests Base branch is healthy, but retries were needed. Could be early signs of flakiness 👀 Healthy 1 View View
unit-tests Base branch is broken, but retries were needed. Could be early signs of flakiness 👀 Broken 1 View View

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mrnicegyu11 mrnicegyu11 merged commit 127a619 into ITISFoundation:master Aug 20, 2025
140 of 148 checks passed
@sanderegg sanderegg added the t:maintenance Some planned maintenance work label Aug 26, 2025
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 2, 2025
61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:director issue related with the director service a:storage issue related to storage service t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants