Skip to content

🎨 Adds support for extra context in conversation updates #8235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 20, 2025
Merged

🎨 Adds support for extra context in conversation updates #8235

merged 6 commits into from
Aug 20, 2025

Conversation

@matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Aug 19, 2025 •
edited
Loading

What do these changes do?

  • Enables conversations to be patched with additional contextual data
  • exposes support group IDs in frontend statics

Related issue/s

How to test

Dev-ops

@matusdrobuliak66
Adds support for extra context in conversation updates
623bb23 
Enables conversations to be patched with additional contextual data,
facilitates richer support flows, and exposes support group IDs in
frontend statics for improved configuration and integration.
@codecov
Copy link

codecov bot commented Aug 19, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.84%. Comparing base (127a619) to head (8555097).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8235      +/-   ##
==========================================
+ Coverage   88.02%   89.84%   +1.81%     
==========================================
  Files        1916     1507     -409     
  Lines       74050    62179   -11871     
  Branches     1301      498     -803     
==========================================
- Hits        65184    55864    -9320     
+ Misses       8475     6186    -2289     
+ Partials      391      129     -262
Flag Coverage Δ
integrationtests 63.98% <50.00%> (-0.05%) ⬇️
unittests 88.24% <100.00%> (+1.57%) ⬆️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 93.04% <100.00%> (+<0.01%) ⬆️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.19% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.03% <ø> (ø)
agent 93.90% <ø> (ø)
api_server 92.84% <ø> (ø)
autoscaling 95.89% <ø> (ø)
catalog 92.34% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 92.37% <ø> (+0.56%) ⬆️
datcore_adapter 97.94% <ø> (ø)
director 76.14% <ø> (ø)
director_v2 90.91% <ø> (-0.13%) ⬇️
dynamic_scheduler 96.27% <ø> (ø)
dynamic_sidecar 90.05% <ø> (ø)
efs_guardian 89.62% <ø> (ø)
invitations 91.44% <ø> (ø)
payments 92.61% <ø> (ø)
resource_usage_tracker 92.13% <ø> (-0.06%) ⬇️
storage 86.71% <ø> (+0.16%) ⬆️
webclient ∅ <ø> (∅)
webserver 88.08% <100.00%> (-0.03%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 127a619...8555097. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matusdrobuliak66
Switches conversation update endpoint from PUT to POST
4d8db04 
Aligns API and routing by changing the HTTP method for updating conversations to POST, ensuring consistency with intended usage.
Adds support for extra context in conversation patch schema for improved extensibility.
@matusdrobuliak66
Switches conversation update HTTP method to PATCH
a44e9b5 
Aligns API and OpenAPI spec with REST conventions by replacing POST with PATCH for updating conversations. Improves semantic clarity for partial updates and enhances adherence to standard practices.uild
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review August 19, 2025 15:16
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) August 19, 2025 15:16
@matusdrobuliak66 matusdrobuliak66 self-assigned this Aug 19, 2025
@matusdrobuliak66 matusdrobuliak66 added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Aug 19, 2025
sanderegg
sanderegg reviewed Aug 19, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a single question, I can put anything of any size in this extra context??

odeimaiz
odeimaiz approved these changes Aug 19, 2025
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@mergify
Copy link
Contributor

mergify bot commented Aug 19, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for 8555097.

❌ Failed Jobs

Pipeline Job Health on base branch Retries 🔍 CI Insights 📄 Logs
PR CI OAS backwards compatibility Unknown 0 View View

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 20, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@matusdrobuliak66 matusdrobuliak66 merged commit d9aef02 into ITISFoundation:master Aug 20, 2025
93 of 95 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 2, 2025
Closed
61 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 18, 2025
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@GitHK GitHK GitHK approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@sanderegg sanderegg sanderegg approved these changes

@pcrespov pcrespov Awaiting requested review from pcrespov pcrespov is a code owner

Assignees

@matusdrobuliak66 matusdrobuliak66

Labels

a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@matusdrobuliak66 @giancarloromeo @GitHK @odeimaiz @sanderegg