-
Notifications
You must be signed in to change notification settings - Fork 32
🎨Director-v0: compatible with both registries + upgraded registry to v3 #8240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨Director-v0: compatible with both registries + upgraded registry to v3 #8240
Conversation
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8240 +/- ##
==========================================
- Coverage 88.02% 87.98% -0.04%
==========================================
Files 1916 1916
Lines 74053 74066 +13
Branches 1301 1301
==========================================
- Hits 65184 65170 -14
- Misses 8478 8504 +26
- Partials 391 392 +1
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
🧪 CI InsightsHere's what we observed from your CI run for 59ad06b. ✅ Passed Jobs With Interesting Signals
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thanks! Supporting both versions is ideal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very very nice, thanks a lot for this! 🎈
|
👍 |



What do these changes do?
The registry v3 deprecates the old schema v1 way of reading labels.
see the following link for info about Docker Image Manifest V2, schema V2 (former was V1 and is deprecated since 2024 apparently). The V2 format also brings multi-arch images (which this PR does not handle).
https://distribution.github.io/distribution/spec/manifest-v2-2/
A test was added to ensure compatibility
Related issue/s
registry:3.0.0#8239How to test
Dev-ops