✨ [Frontend] RTC: Node Lock State #8243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
Contributor
…ore into feature/node-in-use
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements Real-Time Communication (RTC) features for Node Lock State functionality in the frontend. The changes introduce a comprehensive system to track and display when nodes are being used by other users, enhancing collaboration visibility in the platform.
Key changes include:
- Addition of node lock state tracking with user group identification
- Introduction of avatar groups to show current users
- Implementation of locked page UI when nodes are in use by others
- Refactoring of iframe state management to support lock-aware display logic
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
osparc/data/model/NodeLockState.js |
New model class to manage node lock state and current user tracking |
osparc/ui/message/NodeLockedPage.js |
New UI component displaying lock status and active users |
osparc/workbench/NodeUI.js |
Updated to show lock indicators and avatar groups for active users |
osparc/data/model/IframeHandler.js |
Enhanced to handle locked page display and state changes |
osparc/desktop/WorkbenchView.js |
Added centralized iframe state change handling |
osparc/ui/basic/AvatarGroup.js |
Added property to hide current user from avatar display |
osparc/ui/message/Loading.js |
Refactored to use child controls pattern for better extensibility |
osparc/data/model/NodeStatus.js |
Integrated lock state management |
osparc/data/model/Node.js |
Added lock page access and separated progress/state population |
Comments suppressed due to low confidence (1)
services/static-webserver/client/source/class/osparc/data/model/NodeLockState.js:64
- The listener is attached for event "currentUserGroupIds" but the property change event is "changeCurrentUserGroupIds". This inconsistency will prevent the listener from being triggered.
isLockedBySomeoneElse: function() {
services/static-webserver/client/source/class/osparc/ui/message/Loading.js
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/data/model/NodeStatus.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/data/model/NodeLockState.js
Outdated
Show resolved
Hide resolved
…l/NodeLockState.js Co-authored-by: Copilot <[email protected]>
…l/NodeStatus.js Co-authored-by: Copilot <[email protected]>
…ore into feature/node-in-use
odeimaiz
requested review from
GitHK,
alexpargon,
bisgaard-itis,
calys,
giancarloromeo,
matusdrobuliak66,
pcrespov and
sanderegg
|
giancarloromeo
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR implements the frontend part of the node's
lock_statemechanism. The changes introduce a comprehensive system to track and display when nodes are being used by other users, enhancing collaboration visibility in the platform.The node's
lock_statemessage, that comes via websocket, containslockedandcurrent_user_groupidsinformation. This information is used in the following widgets:lockedand if it's the case the avatar group is shown right below it.Related issue/s
How to test
Dev-ops