Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Aug 27, 2025

What do these changes do?

This PR enhances the phone input field for the Request Account functionality by replacing the basic text field with the specialized telephone input widget that includes country code selection and phone number validation. (reported by @calys)

Key changes:

  • Updates existing phone input widget to implement proper form interfaces
  • Aesthetics of the third party IntlTelInput enhanced to feel better integrated
  • Adds support for compact field styling to better integrate with the request account form layout

Country selection in Request Account form and show backend errors in form fields:
ErrotsToForm

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz self-assigned this Aug 27, 2025
@mergify
Copy link
Contributor

mergify bot commented Aug 27, 2025

🧪 CI Insights

Here's what we observed from your CI run for 54f3713.

🟢 All jobs passed!

But CI Insights is watching 👀

@odeimaiz odeimaiz marked this pull request as ready for review August 27, 2025 14:58
…osparc-simcore into enh/request-account-with-phone
@odeimaiz odeimaiz requested a review from Copilot August 27, 2025 15:13

This comment was marked as outdated.

@odeimaiz odeimaiz added this to the Voyager milestone Aug 28, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Aug 28, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the phone input field for the Request Account functionality by replacing the basic text field with a specialized telephone input widget that includes country code selection and phone number validation.

  • Replaces the old osparc.widget.IntlTelInput with a new form-compatible osparc.ui.form.IntlTelInput widget
  • Adds enhanced error handling to display backend validation errors directly in form fields
  • Updates all authentication forms to use a new LoginSinglePlaceholder renderer for better visual consistency

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
intlTelInput.css Adds custom CSS styling for better integration with osparc theme
osparc/widget/IntlTelInput.js Removes old phone input widget implementation
osparc/ui/form/IntlTelInput.js New form-compatible phone input widget with proper interfaces
osparc/utils/Utils.js Adds utility function to map backend errors to form fields
osparc/ui/form/renderer/LoginSinglePlaceholder.js New form renderer for authentication forms
osparc/data/Resources.js Updates error handling to include error arrays in response
Multiple auth UI files Updates to use new phone widget and form renderer

@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label Aug 28, 2025
@odeimaiz
Copy link
Member Author

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Aug 28, 2025

queue

🛑 Configuration not compatible with a branch protection setting

The branch protection setting Require branches to be up to date before merging is not compatible with max_parallel_checks>1, queue_conditions != merge_conditions and must be unset.

@sonarqubecloud
Copy link

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@odeimaiz odeimaiz merged commit c6c1d60 into ITISFoundation:master Aug 28, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request Account: Non required phone field requires country code

3 participants