-
Notifications
You must be signed in to change notification settings - Fork 32
🎨 [Frontend] Request Account: Enhanced Phone input filed #8270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 [Frontend] Request Account: Enhanced Phone input filed #8270
Conversation
🧪 CI InsightsHere's what we observed from your CI run for 54f3713. 🟢 All jobs passed!But CI Insights is watching 👀 |
…osparc-simcore into enh/request-account-with-phone
…osparc-simcore into enh/request-account-with-phone
…ntlTelInput.js Co-authored-by: Copilot <[email protected]>
…osparc-simcore into enh/request-account-with-phone
…osparc-simcore into enh/request-account-with-phone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the phone input field for the Request Account functionality by replacing the basic text field with a specialized telephone input widget that includes country code selection and phone number validation.
- Replaces the old
osparc.widget.IntlTelInputwith a new form-compatibleosparc.ui.form.IntlTelInputwidget - Adds enhanced error handling to display backend validation errors directly in form fields
- Updates all authentication forms to use a new
LoginSinglePlaceholderrenderer for better visual consistency
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
intlTelInput.css |
Adds custom CSS styling for better integration with osparc theme |
osparc/widget/IntlTelInput.js |
Removes old phone input widget implementation |
osparc/ui/form/IntlTelInput.js |
New form-compatible phone input widget with proper interfaces |
osparc/utils/Utils.js |
Adds utility function to map backend errors to form fields |
osparc/ui/form/renderer/LoginSinglePlaceholder.js |
New form renderer for authentication forms |
osparc/data/Resources.js |
Updates error handling to include error arrays in response |
| Multiple auth UI files | Updates to use new phone widget and form renderer |
services/static-webserver/client/source/resource/intl-tel-input/css/intlTelInput.css
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/ui/form/IntlTelInput.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/ui/form/IntlTelInput.js
Outdated
Show resolved
Hide resolved
…ntlTelInput.js Co-authored-by: Copilot <[email protected]>
…osparc-simcore into enh/request-account-with-phone
|
@Mergifyio queue |
🛑 Configuration not compatible with a branch protection settingThe branch protection setting |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx



What do these changes do?
This PR enhances the phone input field for the Request Account functionality by replacing the basic text field with the specialized telephone input widget that includes country code selection and phone number validation. (reported by @calys)
Key changes:
Country selection in Request Account form and show backend errors in form fields:

Related issue/s
How to test
Dev-ops