-
Notifications
You must be signed in to change notification settings - Fork 32
🎨 [Frontend] (Too) light buttons #8274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e into enh/light-buttons
|
🧪 CI InsightsHere's what we observed from your CI run for 188a701. 🟢 All jobs passed!But CI Insights is watching 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses theme-related UI improvements to make buttons more visible and distinguishable in the light theme. The changes ensure buttons don't appear disabled or too faint by adjusting colors and icons.
- Updates button background colors for better contrast in light theme
- Replaces generic text-colored icons with theme-specific black/white variants
- Refactors button click detection to use centralized static methods
- Adds utility method to detect the current theme
Reviewed Changes
Copilot reviewed 9 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| LoggerModel.js | Changes error icon to use red variant instead of generic |
| ImageButtonRenderer.js | Adds static helper method for finding closest button elements |
| ButtonRenderer.js | Introduces BUTTON_CLASS constant and uses it in template |
| ThemeSwitcher.js | Adds isLight() utility method for theme detection |
| SVGImage.js | Uses new theme detection utility instead of direct theme check |
| ColorLight.js | Changes fab-background from white to black with transparency |
| ColorDark.js | Converts input_background from hex to rgb format |
| SubRunsTable.js | Uses theme-specific icons and new button detection method |
| RunsTable.js | Uses theme-specific icons and new button detection method |
Comments suppressed due to low confidence (1)
services/static-webserver/client/source/class/osparc/jobs/RunsTable.js:1
- The theme-based icon selection logic is duplicated here as well. Consider extracting this into a helper function that takes the base icon name and returns the appropriate theme-specific path.
/* ************************************************************************
...ces/static-webserver/client/source/class/osparc/ui/table/cellrenderer/ImageButtonRenderer.js
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/jobs/SubRunsTable.js
Show resolved
Hide resolved
|
@Mergifyio queue |
🛑 Configuration not compatible with a branch protection settingThe branch protection setting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks



What do these changes do?
This PR addresses theme-related UI improvements to make buttons more visible and distinguishable in the light theme. Also, in the case of the buttons in the Activity Overview, the changes ensure buttons don't appear disabled or too faint by adjusting colors and icons.
Before:

After:

Related issue/s
How to test
Dev-ops