Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Aug 28, 2025

What do these changes do?

This PR addresses theme-related UI improvements to make buttons more visible and distinguishable in the light theme. Also, in the case of the buttons in the Activity Overview, the changes ensure buttons don't appear disabled or too faint by adjusting colors and icons.

Before:
Before

After:
After

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz self-assigned this Aug 28, 2025
@odeimaiz odeimaiz added this to the Voyager milestone Aug 28, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Aug 28, 2025
@sonarqubecloud
Copy link

@mergify
Copy link
Contributor

mergify bot commented Aug 28, 2025

🧪 CI Insights

Here's what we observed from your CI run for 188a701.

🟢 All jobs passed!

But CI Insights is watching 👀

@odeimaiz odeimaiz requested a review from Copilot August 28, 2025 15:19
@odeimaiz odeimaiz marked this pull request as ready for review August 28, 2025 15:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses theme-related UI improvements to make buttons more visible and distinguishable in the light theme. The changes ensure buttons don't appear disabled or too faint by adjusting colors and icons.

  • Updates button background colors for better contrast in light theme
  • Replaces generic text-colored icons with theme-specific black/white variants
  • Refactors button click detection to use centralized static methods
  • Adds utility method to detect the current theme

Reviewed Changes

Copilot reviewed 9 out of 16 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
LoggerModel.js Changes error icon to use red variant instead of generic
ImageButtonRenderer.js Adds static helper method for finding closest button elements
ButtonRenderer.js Introduces BUTTON_CLASS constant and uses it in template
ThemeSwitcher.js Adds isLight() utility method for theme detection
SVGImage.js Uses new theme detection utility instead of direct theme check
ColorLight.js Changes fab-background from white to black with transparency
ColorDark.js Converts input_background from hex to rgb format
SubRunsTable.js Uses theme-specific icons and new button detection method
RunsTable.js Uses theme-specific icons and new button detection method
Comments suppressed due to low confidence (1)

services/static-webserver/client/source/class/osparc/jobs/RunsTable.js:1

  • The theme-based icon selection logic is duplicated here as well. Consider extracting this into a helper function that takes the base icon name and returns the appropriate theme-specific path.
/* ************************************************************************

@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label Aug 28, 2025
@odeimaiz
Copy link
Member Author

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Aug 28, 2025

queue

🛑 Configuration not compatible with a branch protection setting

The branch protection setting Require branches to be up to date before merging is not compatible with max_parallel_checks>1, queue_conditions != merge_conditions and must be unset.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@odeimaiz odeimaiz merged commit 0eaea50 into ITISFoundation:master Aug 29, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants